Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StreamDatasetStorage and StreamDataset #1077

Merged
merged 6 commits into from
Jul 7, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jul 5, 2023

Summary

  • Ticket no. 114344
  • Implement StreamDatasetStorage and StreamDataset

How to test

I added some unit tests for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added the FEATURE New feature & functionality label Jul 5, 2023
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jul 5, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…ataset

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review July 6, 2023 04:51
@vinnamkim vinnamkim requested review from a team as code owners July 6, 2023 04:51
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit 6a1bc5a into openvinotoolkit:develop Jul 7, 2023
@vinnamkim vinnamkim deleted the feature/stream-dataset branch July 7, 2023 07:37
vinnamkim added a commit that referenced this pull request Jul 18, 2023
…s() is stacked on the top (#1101)

- Ticket no. 115725
- Fix: Dataset infos() can be broken if a transform not redefining
infos() is stacked on the top
- Enhance the StreamDatasetStorage transform tests added in #1077.
- Test `call_count` as well in the tests to validate stacked transforms.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Co-authored-by: Wonju Lee <wonju.lee@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants