Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OVMSLauncher #1056

Merged
merged 27 commits into from
Jun 27, 2023
Merged

Add OVMSLauncher #1056

merged 27 commits into from
Jun 27, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jun 22, 2023 •
edited
Loading

Summary

  • Ticket no. 112210
  • Implement OVMSLauncher

How to test

I added some tests for this new feature.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim
Update to the latest OV API
19b79a5 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Make specs.json more interpretable
2429d46 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add missing src/datumaro/plugins/sampler/algorithm/__init__.py
d4d0bb7 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Merge branch 'hotfix/make-specs-more-interpretable' into bugfix/updat…
3c9783b 
…e-to-latest-ov-api

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Merge remote-tracking branch 'upstream/develop' into bugfix/update-to…
10ed762 
…-latest-ov-api

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Change ModelInterpreter logic
5005cfb 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Did some refactoring for OpenvinoLauncher and AnnotationMatchers
25a38e5 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add MissingLabelDetection transform
0bb6ee4 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Update CHANGELOG.md
2157b70 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Merge remote-tracking branch 'upstream/develop' into feature/add-miss…
72a013c 
…ing-label-detection-transform

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add OVMS launcher
6aee4df 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Refactor Launcher
5e1f5df 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Remove commented code pieces
aab9693 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix linterror
07a6f1d 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Remove OVMS plugin part
cc49310 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Merge remote-tracking branch 'upstream/develop' into refactor/launcher
82d4945 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix
0e10f25 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Update CHANGELOG
46cc252 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix unittest error
bdbc043 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix
429e2b1 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
More loose constraint
56342d7 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim force-pushed the feature/add-ovms branch 2 times, most recently from bebb23d to b15b267 Compare June 23, 2023 02:59
@vinnamkim vinnamkim marked this pull request as ready for review June 26, 2023 03:07
@vinnamkim vinnamkim requested review from a team as code owners June 26, 2023 03:07
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jun 26, 2023
@vinnamkim vinnamkim added the FEATURE New feature & functionality label Jun 26, 2023
@vinnamkim
Update CHANGELOG.md
a2aa005 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add missing __init__.py
a6566f4 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Update specs.json
87b755b 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim mentioned this pull request Jun 26, 2023
Merged
6 tasks
sooahleex
sooahleex previously approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/datumaro/plugins/ovms_plugin/launcher.py Show resolved Hide resolved
src/datumaro/plugins/ovms_plugin/samples/face_detection.py Outdated Show resolved Hide resolved
@vinnamkim
Add more comments to self._client.predict()
afd0b40 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim merged commit 8b4c5c7 into openvinotoolkit:develop Jun 27, 2023
@vinnamkim vinnamkim deleted the feature/add-ovms branch June 27, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonjuleee wonjuleee wonjuleee approved these changes

@sooahleex sooahleex sooahleex approved these changes

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@sstrehlk sstrehlk Awaiting requested review from sstrehlk sstrehlk is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
FEATURE New feature & functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vinnamkim @wonjuleee @sooahleex