Add Roboflow data formats #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonjuleee
requested review from
vinnamkim,
chuneuny-emily,
sstrehlk and
sooahleex
wonjuleee
added
data formats
vinnamkim
reviewed
Jun 19, 2023
Comment on lines
+128
to
+129
| frame_filename = parsed_record.get("image/filename", None).numpy().decode("utf-8") | ||
| frame_height = tf.cast(parsed_record.get("image/height", 0), tf.int64).numpy().item() | ||
| frame_width = tf.cast(parsed_record.get("image/width", 0), tf.int64).numpy().item() |
There was a problem hiding this comment.
Do we need these change except frame_id? If parsed_record.get("image/filename", None) => None, None.numpy() is impossible. This type of error can be confusing than raising KeyError.
There was a problem hiding this comment.
Alright, I have thought about it, but tf_detection_api is used to contain them. Only the frame_id is not included in Roboflow TFRecord format. Is it better to update others under consideration of KeyError?
There was a problem hiding this comment.
I think that it is better to leave it to raise KeyError in this case because it is genuinely KeyError.
vinnamkim
reviewed
Jun 21, 2023
sooahleex
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.