Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default dtype of load_image() to np.uint8 #1041

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Change default dtype of load_image() to np.uint8 #1041

merged 2 commits into from
Jun 12, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jun 8, 2023 •
edited
Loading

Summary

  • Since default dtype for load_image() has been np.float32, there has been huge meaningless overheads for Geti dataset import pipeline. This PR fixes it.

How to test

Our existing tests cover this PR.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim
Change default dtype of load_image() to np.uint8
77bc0b3 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review June 8, 2023 06:41
@vinnamkim vinnamkim requested review from a team as code owners June 8, 2023 06:41
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jun 8, 2023
@vinnamkim
Update CHANGELOG.md
e86d727 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim merged commit 82f3308 into openvinotoolkit:develop Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonjuleee wonjuleee wonjuleee approved these changes

@sooahleex sooahleex sooahleex approved these changes

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@JihwanEom JihwanEom Awaiting requested review from JihwanEom JihwanEom is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@bonhunko bonhunko Awaiting requested review from bonhunko bonhunko is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinnamkim @wonjuleee @sooahleex