Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook for importing/exporting segmentation data #1023

Merged
merged 5 commits into from
May 25, 2023

Conversation

wonjuleee
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18 🎉

Comparison is base (d309631) 78.58% compared to head (a1dd25d) 78.76%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.3.0    #1023      +/-   ##
==================================================
+ Coverage           78.58%   78.76%   +0.18%     
==================================================
  Files                 237      237              
  Lines               27074    27085      +11     
  Branches             5401     5404       +3     
==================================================
+ Hits                21275    21334      +59     
+ Misses               4534     4491      -43     
+ Partials             1265     1260       -5     
Flag Coverage Δ
macos-11_Python-3.8 77.79% <100.00%> (+0.19%) ⬆️
ubuntu-20.04_Python-3.8 78.75% <100.00%> (+0.19%) ⬆️
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/cityscapes.py 88.54% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@cih9088 cih9088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dataset directory structure for cityscapes should follow this one.

It would be better to revert changes regarding cityscapes dataset and put the cityscapes format documentation link into the notebook and tell users that you should unarchive the zip files in this way to import them into Datumaro.

@wonjuleee
Copy link
Contributor Author

The dataset directory structure for cityscapes should follow this one.

It would be better to revert changes regarding cityscapes dataset and put the cityscapes format documentation link into the notebook and tell users that you should unarchive the zip files in this way to import them into Datumaro.

I updated the Cityscapes document instead. Thank you for letting me know this.

@cih9088
Copy link
Contributor

cih9088 commented May 25, 2023

I updated the Cityscapes document instead. Thank you for letting me know this.

Since we have agreed to change the cityscapes format directory structure, we should let users know it as it might break their workflow when they update Datumaro.
Could you add it to the CHANGELOG.md?

@wonjuleee
Copy link
Contributor Author

I updated the Cityscapes document instead. Thank you for letting me know this.

Since we have agreed to change the cityscapes format directory structure, we should let users know it as it might break their workflow when they update Datumaro. Could you add it to the CHANGELOG.md?

I updated.

@wonjuleee wonjuleee added BUG Something isn't working DOC Improvements or additions to documentation labels May 25, 2023
@wonjuleee wonjuleee merged commit 80b1cc1 into openvinotoolkit:releases/1.3.0 May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants