Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RemoveAnnotations to cope with annotation ids #1004

Merged
merged 6 commits into from
May 19, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented May 18, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Patch coverage: 72.22% and project coverage change: +0.01 🎉

Comparison is base (e2acdf2) 78.52% compared to head (70296ec) 78.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1004      +/-   ##
===========================================
+ Coverage    78.52%   78.53%   +0.01%     
===========================================
  Files          233      233              
  Lines        26757    26782      +25     
  Branches      5323     5330       +7     
===========================================
+ Hits         21010    21034      +24     
- Misses        4497     4499       +2     
+ Partials      1250     1249       -1     
Flag Coverage Δ
macos-11_Python-3.8 77.54% <72.22%> (?)
ubuntu-20.04_Python-3.8 78.51% <72.22%> (+<0.01%) ⬆️
windows-2019_Python-3.8 78.41% <72.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/transforms.py 75.96% <72.22%> (-0.19%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cih9088
cih9088 previously approved these changes May 19, 2023
datumaro/plugins/transforms.py Outdated Show resolved Hide resolved
datumaro/plugins/transforms.py Show resolved Hide resolved
bonhunko
bonhunko previously approved these changes May 19, 2023
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
@wonjuleee wonjuleee dismissed stale reviews from bonhunko and cih9088 via d4685f4 May 19, 2023 02:22
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
vinnamkim
vinnamkim previously approved these changes May 19, 2023
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cih9088
cih9088 previously approved these changes May 19, 2023
@wonjuleee wonjuleee dismissed stale reviews from cih9088 and vinnamkim via 99c012e May 19, 2023 05:15
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit cdc2df6 into openvinotoolkit:develop May 19, 2023
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label May 22, 2023
@vinnamkim vinnamkim added this to the 1.3.0 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants