-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for format-agnostic storage and loading of hashkey #1003
Support for format-agnostic storage and loading of hashkey #1003
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.3.0 #1003 +/- ##
==================================================
+ Coverage 78.58% 78.76% +0.18%
==================================================
Files 237 237
Lines 27074 27085 +11
Branches 5401 5404 +3
==================================================
+ Hits 21275 21333 +58
+ Misses 4534 4492 -42
+ Partials 1265 1260 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
c7bea7f
to
4113433
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do not merge until Refactor: change Exporter::apply() to Exporter::_apply_impl() #1013 is merged.
- This is required for #1003 to reserve a place to put in code snippets for data-format agnostic hash exportation. Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
e927553
to
107a564
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
Summary
hash_key
is only supported for datumaro format. To enhance this, this PR support to format-agnostic save and loadHashKey
of annotationshash_key
fromhash_meta
file during importHashKey
annotation in existed annotationHow to test
Added unittest to check
save_and_load
forDataset
which containsHashKey
in annotations.Checklist
License
Feel free to contact the maintainers if that's a concern.