Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff isort integration #976

Merged
merged 7 commits into from
Mar 23, 2023

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Mar 22, 2023

Description

  • Fix isort configurations in ruff

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (c92fb52) 81.33% compared to head (60b96a1) 81.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #976   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         176      176           
  Lines        6805     6805           
=======================================
  Hits         5535     5535           
  Misses       1270     1270           
Impacted Files Coverage Δ
src/anomalib/utils/hpo/runners.py 0.00% <0.00%> (ø)
src/anomalib/deploy/export.py 100.00% <100.00%> (ø)
src/anomalib/deploy/inferencers/base_inferencer.py 72.60% <100.00%> (ø)
...anomalib/deploy/inferencers/openvino_inferencer.py 87.64% <100.00%> (ø)
src/anomalib/utils/callbacks/export.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have a few comments

.pre-commit-config.yaml Show resolved Hide resolved
Copy link
Contributor Author

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwinvaidya17, I've addressed your comments.

.pre-commit-config.yaml Show resolved Hide resolved
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@samet-akcay samet-akcay merged commit 4f98585 into openvinotoolkit:main Mar 23, 2023
@samet-akcay samet-akcay deleted the fix/ruff-configuration branch November 28, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants