Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nncf compression/quantization #2052

Merged
merged 8 commits into from
May 17, 2024
Merged

Added nncf compression/quantization #2052

merged 8 commits into from
May 17, 2024

Conversation

adrianboguszewski
Copy link
Contributor

@adrianboguszewski adrianboguszewski commented May 10, 2024 •
edited
Loading

📝 Description

  • Added compression/quantization for OpenVINO export

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@adrianboguszewski
Added nncf compression/quantization
90da107 
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
@adrianboguszewski
Docs changes
5307b87 
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
@adrianboguszewski
Merge branch 'refs/heads/main' into ov-nncf
ed11ac3 
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>

# Conflicts:
#	src/anomalib/deploy/__init__.py
#	src/anomalib/deploy/export.py
#	src/anomalib/engine/engine.py
@adrianboguszewski
Minor changes
5369815 
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
@adrianboguszewski adrianboguszewski marked this pull request as ready for review May 15, 2024 08:50
samet-akcay
samet-akcay requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added some comments.

src/anomalib/models/components/base/export_mixin.py Outdated Show resolved Hide resolved
src/anomalib/models/components/base/export_mixin.py Outdated Show resolved Hide resolved
src/anomalib/models/components/base/export_mixin.py Outdated Show resolved Hide resolved
src/anomalib/models/components/base/export_mixin.py Show resolved Hide resolved
@adrianboguszewski
Changes according to review
0f067b2 
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
ashwinvaidya17
ashwinvaidya17 reviewed May 15, 2024
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one comment

src/anomalib/engine/engine.py Show resolved Hide resolved
@adrianboguszewski
Merge branch 'refs/heads/main' into ov-nncf
c698756 
# Conflicts:
#	src/anomalib/engine/engine.py
@adrianboguszewski
Fixes in CLI
d72d075 
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
@samet-akcay samet-akcay enabled auto-merge (squash) May 17, 2024 09:43
@samet-akcay samet-akcay merged commit 4d0beb0 into openvinotoolkit:main May 17, 2024
5 checks passed
@adrianboguszewski adrianboguszewski deleted the ov-nncf branch May 17, 2024 15:20
@samet-akcay samet-akcay added this to the v1.1.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln Awaiting requested review from djdameln djdameln is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianboguszewski @ashwinvaidya17 @samet-akcay