Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Fix dimensionality mismatch issue caused by the new kornia version #1944

Merged

Conversation

samet-akcay
Copy link
Contributor

📝 Description

  • get_gaussian_kernel2d function in kornia returns 1xMxN kernel in the new version. In the previous versions of kornia, on the other hand, this was MxN. This difference causes a dimensionality mismatch issues.
  • 🛠️ Fixes [Bug]: patchcore pytorch error #1798

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
@samet-akcay samet-akcay requested a review from yunchu as a code owner April 3, 2024 11:51
@samet-akcay samet-akcay requested review from ashwinvaidya17 and djdameln and removed request for yunchu April 3, 2024 12:01
Co-authored-by: Dick Ameln <amelndjd@gmail.com>
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 4ca9adb into openvinotoolkit:main Apr 3, 2024
7 of 8 checks passed
@samet-akcay samet-akcay deleted the fix/dimension-issue-kornia branch April 3, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: patchcore pytorch error
2 participants