Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞Fix the error if the device in masks_to_boxes is not both CPU and CUDA #1839

Merged
merged 2 commits into from
Mar 11, 2024
Merged

🐞Fix the error if the device in masks_to_boxes is not both CPU and CUDA #1839

merged 2 commits into from
Mar 11, 2024

Conversation

danylo-boiko
Copy link
Contributor

@danylo-boiko danylo-boiko commented Mar 10, 2024

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Danylo Boiko <danielboyko02@gmail.com>
@danylo-boiko danylo-boiko changed the title Check that the masks are CPU instead of CUDA 🐞 Check that the masks are CPU instead of CUDA Mar 10, 2024
@danylo-boiko danylo-boiko changed the title 🐞 Check that the masks are CPU instead of CUDA 🐞Fix the error if the device in masks_to_boxes is not both CPU and CUDA Mar 10, 2024
Signed-off-by: Danylo Boiko <danielboyko02@gmail.com>
@github-actions github-actions bot added the Docs label Mar 10, 2024
@danylo-boiko danylo-boiko marked this pull request as ready for review March 10, 2024 21:52
@danylo-boiko
Copy link
Contributor Author

@samet-akcay, @ashwinvaidya17, @djdameln, PR is ready for a code review. Please take a look 🙂

@ashwinvaidya17 ashwinvaidya17 self-requested a review March 11, 2024 08:29
@ashwinvaidya17
Copy link
Collaborator

For some reason the tests are skipped in the CI. I ran it locally
image

@ashwinvaidya17 ashwinvaidya17 merged commit 07bf60b into openvinotoolkit:main Mar 11, 2024
5 checks passed
Bepitic pushed a commit to Bepitic/anomalib that referenced this pull request Mar 13, 2024
…DA (openvinotoolkit#1839)

* Check that the masks are CPU instead of CUDA

Signed-off-by: Danylo Boiko <danielboyko02@gmail.com>

* Add a log to the changelog

Signed-off-by: Danylo Boiko <danielboyko02@gmail.com>

---------

Signed-off-by: Danylo Boiko <danielboyko02@gmail.com>
Signed-off-by: Bepitic <bepitic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants