Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Modify all callbacks to return AnomalyModule instead of pl_module #65

Closed
ashwinvaidya17 opened this issue Jan 10, 2022 · 1 comment · Fixed by #208
Closed
Assignees
Labels
Refactor Refactoring is needed
Milestone

Comments

@ashwinvaidya17
Copy link
Collaborator

ashwinvaidya17 commented Jan 10, 2022

Ensure that all callbacks return AnomalyModule instead of pl_module. Otherwise we have to use cast statements. Eg-
compress.py uses pl_module = cast(AnomalyModule, pl_module) to placate mypy. This should be changed to ensure that we always pass AnomalyModule.

@ashwinvaidya17 ashwinvaidya17 added the Refactor Refactoring is needed label Jan 10, 2022
@samet-akcay
Copy link
Contributor

I think this issue could be more generic to address all the callbacks, which should AnomalyModule instead of pl_module

@ashwinvaidya17 ashwinvaidya17 changed the title Refactor: compress.py Refactor: Modify all callbacks to return AnomalyModule instead of pl_module Jan 10, 2022
@samet-akcay samet-akcay added this to the Backlog milestone Apr 4, 2022
@ashwinvaidya17 ashwinvaidya17 self-assigned this Apr 4, 2022
@samet-akcay samet-akcay modified the milestones: Backlog, v0.2.7 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Refactoring is needed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants