Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that best (not latest) model is used for testing after early stopping #63

Closed
djdameln opened this issue Jan 7, 2022 · 1 comment · Fixed by #195
Closed

Verify that best (not latest) model is used for testing after early stopping #63

djdameln opened this issue Jan 7, 2022 · 1 comment · Fixed by #195
Assignees
@djdameln
Labels
Bug Something isn't working Pipeline
Milestone
v0.3.0

Comments

@djdameln
Copy link
Contributor

djdameln commented Jan 7, 2022

In train.py, we call trainer.test right after the model has been trained with trainer.train. It is unclear if this leads to correct behaviour when early stopping is applied. Since we do not explicitly load the best model before calling trainer.test, it could be the case that we simply use the latest model. This should be investigated.
@djdameln
Copy link
Contributor Author

djdameln commented Mar 9, 2022

Can confirm that the latest model is used. This needs to be fixed.

@djdameln djdameln self-assigned this Mar 9, 2022
@samet-akcay samet-akcay added Bug Something isn't working Callbacks Pipeline and removed Callbacks labels Apr 1, 2022
@samet-akcay samet-akcay mentioned this issue Apr 1, 2022
Closed
@samet-akcay samet-akcay added this to the Backlog milestone Apr 4, 2022
@ashwinvaidya17 ashwinvaidya17 mentioned this issue Apr 4, 2022
Closed
@samet-akcay samet-akcay modified the milestones: Backlog, v0.2.7 Apr 4, 2022
@djdameln djdameln mentioned this issue Apr 5, 2022
Merged
11 tasks
@djdameln djdameln linked a pull request Apr 5, 2022 that will close this issue
load best model from checkpoint #195
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djdameln djdameln

Labels
Bug Something isn't working Pipeline
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

load best model from checkpoint openvinotoolkit/anomalib
2 participants
@samet-akcay @djdameln