Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper logging and remove print statements with logger via logger = logging.getLogger("pytorch_lightning") #54

Closed
samet-akcay opened this issue Dec 30, 2021 · 0 comments · Fixed by #241
Closed

Add proper logging and remove print statements with logger via logger = logging.getLogger("pytorch_lightning") #54

samet-akcay opened this issue Dec 30, 2021 · 0 comments · Fixed by #241
Assignees
@samet-akcay
Labels
Enhancement New feature or request Logger
Projects
Feature Requests
Milestone
v0.3.0

Comments

@samet-akcay
Copy link
Contributor

samet-akcay commented Dec 30, 2021 •
edited
Loading

Describe the bug

  • Currently print statements are used to log to console. Instead, logger should be used.
  • Polish out pl loggings.

Expected behavior

  • Modules should get access to the pytorch lightning logger via logger = logging.getLogger("pytorch_lightning") and log to the console.

Hardware and Software Configuration

  • OS: [Ubuntu, OD] - any
  • NVIDIA Driver Version [470.57.02] - any
  • CUDA Version [e.g. 11.4] - any
  • CUDNN Version [e.g. v11.4.120] - any
  • OpenVINO Version [Optional e.g. v2021.4.2] - any

Additional context

  • N/A
@samet-akcay samet-akcay added the Enhancement New feature or request label Jan 7, 2022
@samet-akcay samet-akcay added this to To do in Feature Requests via automation Jan 7, 2022
@samet-akcay samet-akcay added this to the Backlog milestone Apr 4, 2022
@samet-akcay samet-akcay modified the milestones: Backlog, v0.2.7 Apr 13, 2022
@samet-akcay samet-akcay changed the title Remove print statements with logger via logger = logging.getLogger("pytorch_lightning") Add proper logging and remove print statements with logger via logger = logging.getLogger("pytorch_lightning") Apr 17, 2022
This was referenced Apr 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samet-akcay samet-akcay

Labels
Enhancement New feature or request Logger
Projects
No open projects
Feature Requests
To do
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Add console logger openvinotoolkit/anomalib
1 participant
@samet-akcay