Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dataset from benchmarking #300

Closed
3 tasks done
ashwinvaidya17 opened this issue May 9, 2022 · 0 comments · Fixed by #595
Closed
3 tasks done

Set dataset from benchmarking #300

ashwinvaidya17 opened this issue May 9, 2022 · 0 comments · Fixed by #595
Assignees
Labels
Enhancement New feature or request

Comments

@ashwinvaidya17
Copy link
Collaborator

ashwinvaidya17 commented May 9, 2022

As pointed out in #280 (comment), it makes sense to set the dataset from benchmarking_config.yaml rather than each model section. This will ensure that no dataset is misconfigured in a particular model.

Tasks

  • Update documentation
  • Add dataset config section to benchmarking
  • Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant