New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor models to split `torch_model`, `lightning_model` and `anomaly_map`. #211

Closed

samet-akcay opened this issue Apr 8, 2022 · 0 comments · Fixed by #225

Assignees

Labels

Milestone

Contributor

samet-akcay commented Apr 8, 2022

Is your feature request related to a problem? Please describe.

Currently all of the class implementations are stored in a single module called model.py. It would be better to split the implementations.

Describe the solution you'd like

Ideally an algorithm would have torch_model.py, lightning_model.py and anomaly_map.py to store the corresponding implementations.

The text was updated successfully, but these errors were encountered:

samet-akcay added Refactor Model labels

samet-akcay assigned djdameln

samet-akcay added this to the v0.2.7 milestone

djdameln mentioned this issue

Refactor model implementations #225

Merged

11 tasks

samet-akcay closed this as completed in #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment