Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DFKDE NormalityModel to contain the feature extractor #129

Closed
ashwinvaidya17 opened this issue Mar 1, 2022 · 0 comments · Fixed by #207
Closed

Refactor DFKDE NormalityModel to contain the feature extractor #129

ashwinvaidya17 opened this issue Mar 1, 2022 · 0 comments · Fixed by #207
Assignees
@ashwinvaidya17
Labels
Enhancement New feature or request Model
Milestone
v0.3.0

Comments

@ashwinvaidya17
Copy link
Collaborator

Refactor according to comments on PR #122

This would probably work, but I feel like the model would still need another refactoring. Ideally DfkdeModel should be the normality model that contains feature_extractor, pca and kde modules. I guess this would be scope of another PR, but something to keep in mind.
Alternatively, there could be a better naming than NormalityModel if we want to keep NormalityModel. For instance, in DFM, there SingleClassGaussian. Again, in another PR

Reference to comment: #122 (comment)
@ashwinvaidya17 ashwinvaidya17 added the Enhancement New feature or request label Mar 1, 2022
@ashwinvaidya17 ashwinvaidya17 mentioned this issue Mar 1, 2022
Merged
11 tasks
@ashwinvaidya17 ashwinvaidya17 self-assigned this Apr 4, 2022
@samet-akcay samet-akcay added this to the v0.2.7 milestone Apr 4, 2022
@ashwinvaidya17 ashwinvaidya17 mentioned this issue Apr 7, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashwinvaidya17 ashwinvaidya17

Labels
Enhancement New feature or request Model
Projects
Anomalib
Archived in project
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Refactor DFKDE model openvinotoolkit/anomalib
2 participants
@ashwinvaidya17 @samet-akcay