Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitive re-renders on hovering same itinerary at different time #381

Open
binh-dam-ibigroup opened this issue Jun 8, 2021 · 0 comments

Comments

@binh-dam-ibigroup
Copy link
Collaborator

binh-dam-ibigroup commented Jun 8, 2021

For batch routing, hovering between identical itineraries starting at different times triggers a render of each itinerary hovered. This is a subtle behavior that is not noticeable on the UI but may result in extra unnecessary computation.

For testing:

  • Checkout the Transitive styles #366 or more recent branch (the behavior exists on the dev branch prior to that nonetheless).
  • Add a console.log('Transitive render') statement at this line
  • Try this query
  • Hover between the two Walk-to-rail itineraries.
  • Observe the added console logs being printed.

A relevant approach and feedback are found here.

Screen Recording 2021-06-08 at 9 28 48 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant