Clicking "Back" button on "Edit trip" page after logging in causes loop effect

[landonreed]

When clicking the "Back" button after having just logged in to my user account, it will send me back to the URL from which I was just redirected.

[miles-grant-ibigroup]

Have run into this problem again when trying to prevent navigation away from a dirty trip edit page (#400). Using onbeforeunload is supposed to prevent navigation with the browser back and reload buttons. The reload button is blocked, but back is not intercepted. This to me suggests that react-router has already intercepted it and isn't working with it properly.

Resolving this issue will likely involve fixing behavior within the higher level component which is doing the routing

otp-react-redux/lib/components/app/responsive-webapp.js

Line 137 in f18fa7e

window.addEventListener('popstate', handleBackButtonPress)

and including a method to set blocking routing, or removing an item from history.

Would likely involve working on this function

otp-react-redux/lib/actions/ui.js

Lines 113 to 151 in f18fa7e

	export function handleBackButtonPress (e) {
	return function (dispatch, getState) {
	const state = getState()
	const { activeSearchId } = state.otp
	const uiUrlParams = getUiUrlParams(state)
	// Get new search ID from URL after back button pressed.
	// console.log('back button pressed', e)
	const urlParams = coreUtils.query.getUrlParams()
	const previousSearchId = urlParams.ui_activeSearch
	const previousItinIndex = +urlParams.ui_activeItinerary || 0
	const previousSearch = state.otp.searches[previousSearchId]
	if (previousSearch) {
	// If back button pressed and active search has changed, set search to
	// previous search ID.
	if (activeSearchId !== previousSearchId) {
	dispatch(setActiveSearch(previousSearchId))
	} else if (uiUrlParams.ui_activeItinerary !== previousItinIndex) {
	// Active itinerary index has changed.
	dispatch(setActiveItinerary({ index: previousItinIndex }))
	}
	} else {
	// The back button was pressed, but there was no corresponding search
	// found for the previous search ID. Derive search from URL params.
	if (!previousSearchId && activeSearchId) {
	// There is no search ID. Clear active search and from/to
	dispatch(clearActiveSearch())
	dispatch(clearLocation({ type: 'from' }))
	dispatch(clearLocation({ type: 'to' }))
	} else if (previousSearchId) {
	console.warn(`No search found in state history for search ID: ${previousSearchId}. Replanning...`)
	// Set query to the params found in the URL and perform routing query
	// for search ID.
	// Also, we don't want to update the URL here because that will funk with
	// the browser history.
	dispatch(parseUrlQueryString(urlParams))
	}
	}
	}
	}