Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RaptorPathToItineraryMapper Place stopIndex fix #3041

Merged

Conversation

majk1
Copy link
Contributor

@majk1 majk1 commented Apr 19, 2020

To be completed by pull request submitter:

  • issue: Link to or create an issue that describes the relevant feature or bug. Add GitHub keywords to this PR's description (e.g., closes #45).
  • roadmap: Check the roadmap for this feature or bug. If it is not already on the roadmap, PLC will discuss as part of the review process.
  • tests: Have you added relevant test coverage? Are all the tests passing on the continuous integration service (Travis CI)?
  • formatting: Have you followed the suggested code style?
  • documentation: If you are adding a new configuration option, have you added an explanation to the configuration documentation tables and sections?
  • changelog: add a bullet point to the changelog file with description and link to the linked issue

To be completed by @opentripplanner/plc:

  • reviews and approvals by 2 members, ideally from different organizations
  • after merging: update the relevant card on the roadmap

@majk1 majk1 requested a review from a team as a code owner April 19, 2020 16:09
@t2gran
Copy link
Member

t2gran commented Apr 20, 2020

@majk1 Can you describe a little about the context and what the problem is?

@flaktack
Copy link
Contributor

In OTP1 leg.from, leg.to and leg.intermediatePlaces all contained the stopIndex. In the current OTP2 implementation only intermediatePlaces has the stopIndex filled out.

This updates the mapping to fill out stopIndex in all three places.

@majk1 majk1 force-pushed the fix/raptorPath-Place-stopIndex-fix branch from eda667e to 4c675f5 Compare April 28, 2020 09:07
Copy link
Member

@t2gran t2gran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for adding the missing stop indexes.

@t2gran t2gran merged commit cce4e7e into opentripplanner:dev-2.x Apr 29, 2020
@t2gran t2gran added the OTP2 label Apr 29, 2020
@flaktack flaktack deleted the fix/raptorPath-Place-stopIndex-fix branch July 7, 2020 09:21
@abyrd abyrd added this to the 2.0 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants