Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: panic prevention lints #516

Closed
Supremesource opened this issue Jun 8, 2024 · 1 comment
Closed

feat: panic prevention lints #516

Supremesource opened this issue Jun 8, 2024 · 1 comment

Comments

@Supremesource
Copy link

Please add the following clippy lints into Cargo.toml in all pallets utilizing on_initalize :

[lints.clippy]
arithmetic_side_effects = "deny"
indexing_slicing = "deny"
panicking_unwrap = "deny"
out_of_bounds_indexing = "deny"

This will help us improve blockchain safety. Making sure runtime can not panic in on-initilize hook, halting the block production.
@distributedstatemachine
Copy link
Contributor

distributedstatemachine commented Jun 10, 2024 •
edited
Loading

The bulk of this is covered here: #485

cc @keithtensor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@distributedstatemachine @Supremesource