Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Delegate Take #314

Closed
2 tasks done
distributedstatemachine opened this issue Apr 11, 2024 · 3 comments
Closed
2 tasks done

Changing Delegate Take #314

distributedstatemachine opened this issue Apr 11, 2024 · 3 comments
Assignees
Labels
red team feature development, etc

Comments

@distributedstatemachine
Copy link
Contributor

distributedstatemachine commented Apr 11, 2024

Description

Currently, the delegation rewards distribution system in our blockchain project has a limitation where delegates' commission rates (takes) are hardcoded at 18%. This inflexibility prevents delegates from adjusting their commission rates based on market conditions and their individual strategies.

As a result, delegates often resort to off-chain agreements and rebate systems to attract delegators and remain competitive. This creates market inefficiencies and hinders the overall user experience within our ecosystem.

Implementing the ability for delegates to alter their commission rates within the defined range would provide significant value to both delegates and delegators, enabling them to make informed decisions and adapt to evolving market dynamics.

Acceptance Criteria

  • Delegates should be allowed to set their commission rates (takes) within the range of 0% to 18%.
  • To prevent frequent changes and ensure stability, delegates should only be allowed to increase their commission rates once every 30 days (monthly).
  • The new commission rate should be applied to future rewards distributions and not affect previously distributed rewards.

Tasks

  • Implement a function in the delegation contract to allow delegates to change their commission rates (takes) within the specified range.
  • Add necessary checks to ensure that delegates can only increase their commission rates once every 30 days.

Additional Considerations

  • Do we need some notification system to broadcast delegate rate changes ?

Related Links

@surcyf123
Copy link

High priority

@gztensor
Copy link
Contributor

It is addressed in this PR: #319, which is now merged to stao branch. Should be in development soon :)

@sam0x17
Copy link
Contributor

sam0x17 commented May 2, 2024

fixed in #319

@sam0x17 sam0x17 closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red team feature development, etc
Projects
None yet
Development

No branches or pull requests

4 participants