Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to document icon sources #838

Closed
wants to merge 3 commits into from

Conversation

matkoniecz
Copy link
Contributor

first step toward #314

not fully explaining what is going on, not sure is it the best place to document it but at this point I think that substandard attempt is better than nothing :)

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-838--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Mar 25, 2023

Note that #839 apparently has not worked - and I am unsure why.

Are there additional restrictions on Font Awesome? Additional steps being required? I made some typo mistake?

EDIT: now fixed

@matkoniecz matkoniecz marked this pull request as draft March 25, 2023 17:01
@matkoniecz matkoniecz marked this pull request as ready for review March 27, 2023 17:04
@tyrasd tyrasd added the documentation Improvements or additions to documentation label Mar 27, 2023
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently, I had created the ICONS.md page on the schema-builder repo to document this. Wouldn't it be better to only put a link to that page here in the readme, in order to not duplicate the content unnecessarily.

@matkoniecz
Copy link
Contributor Author

Oh, definitely - link to that would be strictly superior and resolve #314 .

@tyrasd tyrasd closed this in e4b04aa Mar 28, 2023
@matkoniecz matkoniecz deleted the patch-8 branch April 14, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants