Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gender field on hairdresser #575

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

nlehuby
Copy link
Contributor

@nlehuby nlehuby commented Sep 3, 2022

it will be very useful to distinguish barber shops from regular hairdressers

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks are needed (see below).

I'm not super happy with reusing the gender preset for this, as the description "Gender" could be maybe a bit confusing (at least in some translations). But as I'm also not sure what a better description could be (Haircut Style perhaps? or Customers Served??) right now, so I guess it's fine for the moment.

data/presets/shop/hairdresser.json Outdated Show resolved Hide resolved
data/presets/shop/hairdresser.json Show resolved Hide resolved
nlehuby and others added 2 commits September 9, 2022 15:42
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
@nlehuby nlehuby requested a review from tyrasd September 9, 2022 13:43
@tyrasd tyrasd merged commit d85fb42 into openstreetmap:main Sep 9, 2022
@nlehuby nlehuby deleted the hairdresser_gender branch September 9, 2022 14:14
@nlehuby
Copy link
Contributor Author

nlehuby commented Sep 9, 2022

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants