Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more barrier presets #506

Merged
merged 12 commits into from
Jun 23, 2022
Merged

Add more barrier presets #506

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
62e1cc7
Add more barrier presets
arch0345 Jun 18, 2022
f88a1b9
Rope Barrier -> Rope Fence
arch0345 Jun 18, 2022
57721eb
Add terms to Hampshire Gate preset
arch0345 Jun 21, 2022
2ace6ff
Add `wheelchair` to moreFields in Motorcycle Barrier preset
arch0345 Jun 21, 2022
2e4f6ba
Remove fields from Wicket Gate preset
arch0345 Jun 21, 2022
536a8ee
Change Planter preset
arch0345 Jun 21, 2022
3780657
npm run lint:fix
arch0345 Jun 21, 2022
bb8c053
Rename planter_barrier.json to barrier_planter.json
arch0345 Jun 21, 2022
3bf81f8
Update field name
arch0345 Jun 21, 2022
0117fa8
Remove fields
arch0345 Jun 21, 2022
2cccadf
be more restrictive on planter geometry types
tyrasd Jun 22, 2022
87e795f
add non-searchable "Planter (Barrier)" preset
tyrasd Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions data/fields/maxwidth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"key": "maxwidth",
"type": "roadheight",
"label": "Max Width",
"snake_case": false
}
11 changes: 11 additions & 0 deletions data/presets/barrier/_ditch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"icon": "maki-roadblock",
"geometry": [
"line"
],
"tags": {
"barrier": "ditch"
},
"name": "Ditch",
"searchable": false
}
11 changes: 11 additions & 0 deletions data/presets/barrier/_handrail.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"icon": "temaki-railing",
"geometry": [
"line"
],
"tags": {
"barrier": "handrail"
},
"name": "Handrail",
"searchable": false
}
15 changes: 15 additions & 0 deletions data/presets/barrier/_log.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"icon": "maki-roadblock",
"fields": [
"access"
],
"geometry": [
"vertex",
"line"
],
"tags": {
"barrier": "log"
},
"name": "Fallen Tree",
"searchable": false
}
16 changes: 16 additions & 0 deletions data/presets/barrier/bump_gate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"icon": "maki-roadblock",
"fields": [
"access"
],
"geometry": [
"vertex"
],
"terms": [
"drive-through gate"
],
"tags": {
"barrier": "bump_gate"
},
"name": "Bump Gate"
}
19 changes: 19 additions & 0 deletions data/presets/barrier/bus_trap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"icon": "maki-roadblock",
"fields": [
"access"
],
"moreFields": [
"maxwidth"
],
"geometry": [
"vertex"
],
"terms": [
"car trap"
],
"tags": {
"barrier": "bus_trap"
},
"name": "Bus Trap"
}
18 changes: 18 additions & 0 deletions data/presets/barrier/cable_barrier.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"icon": "maki-roadblock",
"fields": [
"height",
"material"
],
"geometry": [
"line"
],
"tags": {
"barrier": "cable_barrier"
},
"terms": [
"guard cable",
"wire rope safety barrier"
],
"name": "Cable Barrier"
}
17 changes: 17 additions & 0 deletions data/presets/barrier/full-height_turnstile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"icon": "maki-roadblock",
"fields": [
"access"
],
"geometry": [
"vertex"
],
"terms": [
"baffle gate",
"turnstyle"
],
"tags": {
"barrier": "full-height_turnstile"
},
"name": "Full-height Turnstile"
arch0345 marked this conversation as resolved.
Show resolved Hide resolved
}
13 changes: 13 additions & 0 deletions data/presets/barrier/hampshire_gate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"icon": "temaki-gate",
"fields": [
"access"
],
"geometry": [
"vertex"
],
"tags": {
"barrier": "hampshire_gate"
},
"name": "Hampshire Gate"
arch0345 marked this conversation as resolved.
Show resolved Hide resolved
arch0345 marked this conversation as resolved.
Show resolved Hide resolved
}
29 changes: 29 additions & 0 deletions data/presets/barrier/jersey_barrier.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"icon": "maki-roadblock",
"fields": [
"height",
"material"
],
"moreFields": [
"access"
],
"geometry": [
"point",
"line"
],
"tags": {
"barrier": "jersey_barrier"
},
"terms": [
"concrete median",
"concrete barrier",
"constant-slope barrier",
"f-shape barrier",
"k-rail",
"median",
"new jersey wall",
"ontario tall wall",
"plastic barrier"
],
"name": "Jersey Barrier"
}
13 changes: 13 additions & 0 deletions data/presets/barrier/motorcycle_barrier.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"icon": "maki-roadblock",
"fields": [
"access"
],
arch0345 marked this conversation as resolved.
Show resolved Hide resolved
"geometry": [
"vertex"
],
"tags": {
"barrier": "motorcycle_barrier"
},
"name": "Motorcycle Barrier"
}
11 changes: 11 additions & 0 deletions data/presets/barrier/planter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"icon": "maki-garden",
"geometry": [
"vertex",
"line"
],
"tags": {
"barrier": "planter"
},
"name": "Planter Barrier"
}
17 changes: 17 additions & 0 deletions data/presets/barrier/rope.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"icon": "temaki-rope_fence",
"fields": [
"access"
],
"moreFields": [
"wheelchair"
arch0345 marked this conversation as resolved.
Show resolved Hide resolved
],
"geometry": [
"vertex",
"line"
],
"tags": {
"barrier": "rope"
},
"name": "Rope Fence"
}
25 changes: 25 additions & 0 deletions data/presets/barrier/wicket_gate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"icon": "temaki-gate",
"geometry": [
"vertex",
"line"
],
"fields": [
"access",
"locked",
"wheelchair",
"opening_hours",
"height",
"material"
],
"moreFields": [
"colour",
"manufacturer",
"operator",
"ref"
arch0345 marked this conversation as resolved.
Show resolved Hide resolved
],
"tags": {
"barrier": "wicket_gate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this tag refer to the way the gate is constructed (small), its purpose (pedestrian access), or its location (secondary), or some combination? I’m finding the preset difficult to translate due to this ambiguity.

Copy link
Member

@tyrasd tyrasd Jul 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, the term refers only to a secondary gate for pedestrians near (or in1) a larger gate.

Footnotes

  1. I would say that in OSM the barrier=wicket_gate probably only applies to the situation where the wicket is actually a separate entrance (as in this example), and not for wicket doors which are built directly into a large gate (example). The latter should probably be modeled as an attribute of the main gate (e.g. barrier=gate + wicket=yes), I assume. ↩

},
"name": "Wicket Gate"
}