Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aliases and terms for shop=* presets #475

Merged
merged 11 commits into from
Aug 8, 2022
Merged

Add aliases and terms for shop=* presets #475

merged 11 commits into from
Aug 8, 2022

Conversation

westnordost
Copy link
Contributor

@westnordost westnordost commented May 31, 2022 •
edited
Loading

Also, corrected shop=deli preset name. In American English, "Deli" means something else as what shop=deli is originally defined with.

Sources: English Wikipedia, OpenStreetMap Wiki

@1ec5 1ec5 mentioned this pull request May 31, 2022
Open
1ec5
1ec5 reviewed May 31, 2022
View reviewed changes
data/presets/shop/car_repair.json Outdated Show resolved Hide resolved
data/presets/shop/antiques.json Outdated Show resolved Hide resolved
data/presets/shop/books.json Outdated Show resolved Hide resolved
data/presets/shop/car_repair.json Outdated Show resolved Hide resolved
data/presets/shop/convenience.json Outdated Show resolved Hide resolved
data/presets/shop/gift.json Show resolved Hide resolved
data/presets/shop/health_food.json Outdated Show resolved Hide resolved
data/presets/shop/newsagent.json Outdated Show resolved Hide resolved
data/presets/shop/pawnbroker.json Outdated Show resolved Hide resolved
data/presets/shop/variety_store.json Outdated Show resolved Hide resolved
1ec5
1ec5 reviewed Jun 1, 2022
View reviewed changes
data/presets/shop/deli.json Outdated Show resolved Hide resolved
@westnordost
Copy link
Contributor Author

Alright, thanks for the review you all. All suggestions are incorporated now. This PR is ready for final review by the repo maintainer(s).

@zekefarwell zekefarwell mentioned this pull request Jun 19, 2022
Open
8 tasks
@tyrasd tyrasd force-pushed the main branch 2 times, most recently from 9d3204d to 49f529e Compare June 22, 2022 16:19
@tyrasd tyrasd added the new-label changes the name, aliases or terms of a preset label Aug 7, 2022
tyrasd
tyrasd requested changes Aug 7, 2022
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the PR and please excuse the rather long delay. Please see a few minor questions and remarks below.

data/presets/shop/butcher.json Outdated Show resolved Hide resolved
data/presets/shop/butcher.json Show resolved Hide resolved
data/presets/shop/deli.json Outdated Show resolved Hide resolved
data/presets/shop/deli.json Show resolved Hide resolved
@westnordost
Copy link
Contributor Author

Ready for re-review.

@tyrasd tyrasd merged commit d7693e7 into openstreetmap:main Aug 8, 2022
@1ec5 1ec5 mentioned this pull request Jul 29, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 left review comments

@tyrasd tyrasd tyrasd approved these changes

@ZeLonewolf ZeLonewolf ZeLonewolf left review comments

@zekefarwell zekefarwell zekefarwell approved these changes

@michaelblyons michaelblyons michaelblyons approved these changes

Assignees
No one assigned
Labels
new-label changes the name, aliases or terms of a preset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@westnordost @zekefarwell @1ec5 @tyrasd @michaelblyons @ZeLonewolf