Created translatable strings for fuel types, crossings, entrances and substations #467
Conversation
Miroff
changed the title
|
|
This would fix #404. |
data/fields/crossing.json
Outdated
| "strings": { | ||
| "options": { | ||
| "traffic_signals": "Traffic signals and marking", | ||
| "uncontrolled": "Marking only", |
There was a problem hiding this comment.
FYI, crosswalk classification is being discussed in #408.
data/fields/crossing.json
Outdated
| "options": { | ||
| "traffic_signals": "Traffic signals and marking", | ||
| "uncontrolled": "Marking only", | ||
| "unmarked": "No Traffic Signals, no marking", |
There was a problem hiding this comment.
These values are using a mix of Title Case and Sentence case. I agree that title case can be annoying for long values, but the fields should at least be internally consistent.
data/fields/entrance.json
Outdated
| "label": "Type", | ||
| "strings": { | ||
| "options": { | ||
| "yes": "Unspecified", |
There was a problem hiding this comment.
Some possibly relevant naming considerations for entrance types in streetcomplete/StreetComplete#3949.
tyrasd
force-pushed
the
main
branch
2 times, most recently
from
9d3204d
to
49f529e
Compare
|
I've tweaked this quite a bit and finally merged as 95c206b (sorry for the extra commits in your main branch @Miroff). I excluded the crossings field, as that is now handled in #590. I also changed the way the localized fuel field works: instead of duplicating the preset for every region, I made the field region-specific and let it inherit the strings from the global field. That avoids that translators have to translate the same string more than once, and should scale pretty nicely if you want to add more countries. Further, I removed lesser used fuel values (cut-off approx ~1000 usages with exceptions for the H2 types) and reworded the substation value strings slightly. |
If this PR was merged, I'm going to create similar preset for Belarus.