Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flashing_lights field #449

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented May 2, 2022

This PR adds a field for flashing_lights which will be used for Unmarked/Marked Crossing presets. The key flashing_lights currently has around 2.5K uses. I've added values listed on the wiki article (no, yes, button, always, sensor, and button;sensor). Crossings with flashing lights are pretty common in the US, here's an example from Alexandria, VA:
image

@tyrasd
Copy link
Member

tyrasd commented May 12, 2022

Good suggestion! I would only request one small change: given that the current usage is very small (less than 0.5% of crossings use the tag), I think it would be better to add this one as an optional field (moreFields). What do you think?

@arch0345
Copy link
Contributor Author

Good suggestion! I would only request one small change: given that the current usage is very small (less than 0.5% of crossings use the tag), I think it would be better to add this one as an optional field (moreFields). What do you think?

Yeah, this makes sense

@tyrasd tyrasd merged commit be3954f into openstreetmap:main May 16, 2022
@arch0345 arch0345 deleted the flashing-lights branch May 16, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants