Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extened search terms for man_made=monitoring_station #1347

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mnalis
Copy link
Contributor

@mnalis mnalis commented Sep 25, 2024

"Monitoring station" is sometimes hard to find as people don't look for that name specifically, e.g. when one searches for "water level" or "bicycle_counter" (that one specifically has been requested elsewhere, e.g. Zverik/every_door#772)

Added search terms should help users found few extra uses of monitoring/measurement stations.

Description, Motivation & Context

Related issues

Closes #1331

Links and data

Relevant OSM Wiki links:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

generally, but also specifically for bicycle counters and water levels
Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator

tordans commented Sep 27, 2024

A nice follow up would be to add translated keys (title + description) to those values
image

@tordans
Copy link
Collaborator

tordans commented Sep 27, 2024

This looks good to me, thanks.

(Test)

@tordans tordans merged commit 8a37712 into openstreetmap:main Sep 27, 2024
5 checks passed
@tordans tordans added the new-label changes the name, aliases or terms of a preset label Sep 27, 2024
@mnalis mnalis deleted the monitoring-station-terms branch September 27, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-label changes the name, aliases or terms of a preset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bicycle traffic counter
2 participants