Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets for meadow=meadow_orchard, orchard=meadow_orchard #1218

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented May 11, 2024

Following the conversation at #1096 this adds 2 presets for "Streuobstwiese".


TODOs


The moreTags are based on


The locationSet is set to EU. That looks like the easiest way to catch the most relevant countries without starting to cherry-pick some.

orchard=meadow_orchard

meadow=meadow_orchard

If someone knows hot to modify https://qlever.cs.uni-freiburg.de/osm-planet/lPnRP3 we could see which countries appart from the DACH region actually use the tag ATM.

Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans tordans changed the title Add presets for meadow=meadow_orchard, orchard=meadow_orchard Add presets for meadow=meadow_orchard, orchard=meadow_orchard May 11, 2024
@tordans
Copy link
Collaborator Author

tordans commented May 23, 2024

Update: Added the missing Wikidata item

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great as a regional preset. I only have a small and a tiny remark about the preset labels, see below. Otherwise this would be good to be merged for the next release

data/presets/landuse/meadow_orchard/meadow.json Outdated Show resolved Hide resolved
data/presets/landuse/meadow_orchard/orchard.json Outdated Show resolved Hide resolved
Co-authored-by: Martin Raifer <martin@raifer.tech>
@tordans
Copy link
Collaborator Author

tordans commented Jul 22, 2024

@tyrasd thank for the "name" improvements.
One other thing we could change is to make one preset the main one and have the other look up fields and moreFields from there. But on the other hand the complexity is quite low ATM as well…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants