-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community centre #1200
Community centre #1200
Conversation
🍱 You can preview the tagging presets of this pull request here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiptoptom in general this looks good. Could you please add some context to your PR to make it easer to review and also add some example links to those places using the preview that was linked in the PR by the github action. Please add usage stats on the given presets as well.
For example, why did you add separate presets per center-type? They all use the same fields and icon of their parent, so we might as well just use the parent + the new field?
One specific think I wonder is: You reference #1015 which talks about https://wiki.openstreetmap.org/wiki/Key:community_centre:for but your PR does not use this tag. Is this because you consider this something to be added later or are there other reasons?
Thanks for this PR!
Update: Two more things we need to check
- What does the search look like with those presets, are there duplicated results?
- Are there good Wikidata items already, so we get a nice info-(i) text? (Please add screenshots) (See https://github.com/openstreetmap/id-tagging-schema/pull/1239/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35R13)
I have made various presets, as some of the names have little to do with "community center". For example, a club home of a sports club would not be called a community center but a club home. |
I just wanted to put them in copy, as it is something similar. |
community_centre = village_hall community_centre = club_home community_centre = cultural_centre |
|
@tiptoptom do you know more about the values that the "most used values" feature of the dropdown shows? |
@tiptoptom One thing we should do before merging is improving the info- Eg links to https://wiki.openstreetmap.org/wiki/Item:Q6740 You might need to add new wikidata items for those. Or add an explicit reference https://github.com/ideditor/schema-builder?tab=readme-ov-file#reference to the sub presets. |
@tiptoptom what are your thoughts on adding the sub-group-dropdown to the sub-presets as well? Right now it looks like this. The additional dropdown could be the first item on this fieldset |
I think I just took the values that have their own wiki page. Should we perhaps add the values from this table? |
How can I do this?
Do I understand correctly that this would be the alternative to a newly created wikidata item? |
Sounds reasonable 👍 |
There are docs on this worked on in https://github.com/openstreetmap/id-tagging-schema/pull/1257/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R52
The reference is needed to tell the editor which key to use when a user clicks on the info-i. |
I think I've worked through almost everything now and only the following wikidata items are missing:
|
I've added data items for |
This looks good, thanks for the updates! The one thing that is not ideal, still, is the club stuff.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one thing that I thing we should look at. Happy to merge afterwards.
CC: #1015 #605