Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parking:orientation field is showing additional undocumented rare values #553

Closed
jdhoek opened this issue Jul 30, 2022 · 2 comments · Fixed by #554
Closed

parking:orientation field is showing additional undocumented rare values #553

jdhoek opened this issue Jul 30, 2022 · 2 comments · Fixed by #554
Labels
bug Something isn't working

Comments

@jdhoek
Copy link
Contributor

jdhoek commented Jul 30, 2022

I've noticed that ID is suggesting two additional undocumented and nearly unused values for parking:orientation:

2022-07-30-205459_2560x1440_scrot

The value orthogonal (85 uses) seems like an undocumented alternative for perpendicular and marking is used just 16 times (no idea what that means).

Why are these showing up in the list? Is this automated based on TagInfo data?

Is it possible to leave them out?
@jdhoek jdhoek added the bug Something isn't working label Jul 30, 2022
@arch0345
Copy link
Contributor

Yeah, it looks like these are fetched from Taginfo:
https://github.com/ideditor/schema-builder#autosuggestions

jdhoek added a commit to jdhoek/id-tagging-schema that referenced this issue Aug 1, 2022
@jdhoek
Disable TagInfo-suggestions of parking:orientation
01c83fa 
The `parking:orientation` tag has three common and documented values.
Currently no other values are in common use. With `autoSuggestions`
turned on, two rare values (`orthogonal`, 80 uses, ostensibly a synonym
of `perpendicular` and `marking` with only 16 uses) are included in the
combo-box, making these seem like common and valid options.

Fixes openstreetmap#553.
@jdhoek jdhoek mentioned this issue Aug 1, 2022
Merged
@jdhoek
Copy link
Contributor Author

jdhoek commented Aug 1, 2022

@arch0345 Interesting. Weird how that is pulling in tag values used only 80 and 16 times. That's bound to cause mappers to choose bad values.

@jdhoek jdhoek mentioned this issue Aug 1, 2022
Closed
tyrasd pushed a commit that referenced this issue Aug 1, 2022
@jdhoek
Disable TagInfo-suggestions of parking:orientation (#554)
c6cb076 
The `parking:orientation` tag has three common and documented values.
Currently no other values are in common use. With `autoSuggestions`
turned on, two rare values (`orthogonal`, 80 uses, ostensibly a synonym
of `perpendicular` and `marking` with only 16 uses) are included in the
combo-box, making these seem like common and valid options.

Fixes #553.
tyrasd added a commit that referenced this issue Aug 1, 2022
@tyrasd
add tag upgrade rule for parking:orientation=orthogonal -> `=perpen…
7e176b5 
…dicular`

see #553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable TagInfo-suggestions of parking:orientation jdhoek/id-tagging-schema
2 participants
@jdhoek @arch0345