Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for parcel locker tagged with deprecated scheme suggests wrong tag value #364

Closed
riQQ opened this issue Jan 22, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@riQQ
Copy link

riQQ commented Jan 22, 2022

The value for parcel_pickup is incorrectly proposed as no although it was previously tagged as available (vending=parcel_pickup[;...]).

Actual

- amenity=vending_machine
+ amenity=parcel_locker
+ parcel_mail_in=yes
+ parcel_pickup=no
- vending=parcel_pickup;parcel_mail_in

Expected

- amenity=vending_machine
+ amenity=parcel_locker
+ parcel_mail_in=yes
+ parcel_pickup=yes
- vending=parcel_pickup;parcel_mail_in

iD screenshot

Overpass turbo query to find affected elements

node
  [amenity=vending_machine]
  [vending="parcel_pickup;parcel_mail_in"]
  ({{bbox}});
out;

This change was implemented in #339 / #358.

@riQQ riQQ changed the title Proposed fix for parcel locker tagged with old scheme suggests wrong tag value Proposed fix for parcel locker tagged with deprecated scheme suggests wrong tag value Jan 22, 2022
riQQ added a commit to riQQ/id-tagging-schema that referenced this issue Jan 22, 2022
@tyrasd tyrasd added the bug Something isn't working label Jan 24, 2022
@tyrasd tyrasd closed this as completed in 609c017 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants