Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use embassy=yes instead of embassy=embassy #340

Closed
overflorian opened this issue Jan 7, 2022 · 6 comments · Fixed by #343
Closed

Use embassy=yes instead of embassy=embassy #340

overflorian opened this issue Jan 7, 2022 · 6 comments · Fixed by #343
Labels
new-value

Comments

@overflorian
Copy link

Hi,
In iD, I propose to stop suggesting the use of embassy=embassy
An embassy should instead be tagged embassy=yes, as detailled in the documentation.

Current situation

For an embassy the following tags are used:

  • office=diplomatic
  • diplomatic=embassy
  • both values embassy=embassy and embassy=yes are proposed to the user

Proposed evolution

The editor stop to suggest embassy=embassy and only propose the following tags to use, as described in the documentation:

  • embassy=yes - an classic embassy with an ambassador
  • embassy=high_commission - high commission
  • embassy=nunciature - diplomatic mission sent from the Vatican
  • embassy=interests_section - a country that represents another sovereign state in a country where it lacks its own diplomatic representation
  • embassy=mission - diplomatic mission to or from a multilateral organization such as the United Nations
  • embassy=delegation - a delegation is headed by an ambassador
  • embassy=branch_embassy - like trade office or cultural centre
  • embassy=residence
@tyrasd
Copy link
Member

tyrasd commented Jan 7, 2022

Do I understand you correctly that the issue is that the value embassy is proposed in the "Type" field of the embassy preset? See screenshot below:

@overflorian
Copy link
Author

Yes

@matkoniecz
Copy link
Contributor

#341 is related

tyrasd added a commit that referenced this issue Jan 10, 2022
@tyrasd
specify values for "embassy" tag (closes #340)
75bb535
This was referenced Jan 10, 2022
Merged
Merged
tyrasd added a commit that referenced this issue Jan 10, 2022
@tyrasd @matkoniecz
specify values for "embassy" tag (#343)
d279c23 
* embassy=embassy to embassy=yes

embassy=embassy is an unwanted tagging fueled by iD presets showing top taginfo suggestions

there was confused philosophical discussion about deprecations on tagging mailing list - but of all involved noone considered embassy=embassy as a good idea

see https://lists.openstreetmap.org/pipermail/tagging/2022-January/063459.html

* specify values for "embassy" tag (closes #340)

Co-authored-by: Mateusz Konieczny <matkoniecz@gmail.com>
@overflorian
Copy link
Author

Hi, you closed this issue but I still see the "embassy" value in the form. Should I just wait for your implementation to appear?
Thanks.

@tyrasd
Copy link
Member

tyrasd commented Jan 10, 2022

The changes will be published (i.e. made available for the public iD editor) in the next release of this package. I'm still in the process of working through the backlog of the issues of this repository right now, but am planning to publish a release relatively soon (in one or two weeks presumably).

@overflorian
Copy link
Author

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-value
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

specify values for "embassy" tag openstreetmap/id-tagging-schema
3 participants
@matkoniecz @tyrasd @overflorian