Fix connect features with uncontrolled crossing #9443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In openstreetmap/id-tagging-schema#590, the (searchable) Marked Crossing preset was changed to use
crossing=uncontrolledinstead ofcrossing=marked. This PR fixes a similar issue to #9176 in which using Connect the features with a Marked Crossing way adds a generic highway=crossing node as opposed to a Marked Crossing node.I wasn't sure if the changes made to
test/spec/validations/crossing_ways.jsin #9181 was needed so I just made changes tomodules/validations/crossing_ways.js. I tested it locally and it seems to work fine.