Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name-suggestion-index v6 #8305

Merged
merged 58 commits into from
Jul 6, 2021
Merged

Name-suggestion-index v6 #8305

merged 58 commits into from
Jul 6, 2021

Commits on Jan 5, 2021

  1. Update to name-suggestion-index v5

    Merge in NSI presets after UI has initialized
    bhousel committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    b0800c1 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Update presetIndex to resolve and index locationSets

    Added a deferred work queue to do this with requestIdleCallback in the background
    bhousel committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    9eb6f87 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Configuration menu
    Copy the full SHA
    0ad7de0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab85590 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    271e1c2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c4daf1b View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Have mergeLocationSets work on Objects, add locationSetID property

    This means less work for the other parts of the code,
    now they don't need to chain that extra step after the promise.
    bhousel committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    868db88 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Configuration menu
    Copy the full SHA
    2d8c907 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Configuration menu
    Copy the full SHA
    d3fb8c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Configuration menu
    Copy the full SHA
    0b3795c View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Configuration menu
    Copy the full SHA
    a38a93c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f39f73e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4228b65 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Fix teh misspellings

    bhousel committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    74d2825 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a325535 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f61a3ef View commit details
    Browse the repository at this point in the history
  4. Preserve name value if this preset shows brand or operator field

    This also fixes the logic for calculating whether the preset shows a
    `brand` or `operator` field - it needs to use `fields()` to actually
    resolve the fields, as these fields can be inherited from another preset.
    
    This also includes a change to match "primary" names before
    "alternate" names (aka the "Baby Gap" / "Gap" problem)
    bhousel committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    96298f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Configuration menu
    Copy the full SHA
    4f369a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. Rewrite the validator in ES6/Promises, several improvements here:

    - implements a validation work queue, jobs are run during browser idle callbacks
    - when merging base entities, don't run validations 2x on both base and head graphs (this was wasteful)
    - keep track of resolved issues in a separate set (it's not a simple compare of base/head anymore)
      this happens after validation queue is empty and avoids race conditions and inaccurate resolved counts
    bhousel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    11201eb View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Allow validators to return provisional results, revalidate after delay

    Also add a ton of commments to validator.js
    bhousel committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    f87c2d9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #8319 from openstreetmap/promisify_validation

    Promisify validation
    bhousel authored Jan 27, 2021
    Configuration menu
    Copy the full SHA
    16f2f07 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3640e15 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Adust NSI matching validation code:

    - don't try matching semicolon-separated lists to NSI
    - better matching for flagpoles with a `country` tag
    - better lists of namelike keys (don't match flag operator)
    
    see: #8305 (comment)
    bhousel committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    b032cd9 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Also include operator:wikidata as a wikidata tag

    osmEntity#hasWikipedia was only used by the suspicious_name validator
    bhousel committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    3665f80 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Remove the brand combo from the name field

    This has caused problems going back a long time, and now that we have a validator
    and very visible brand presets with logos, it's not necessary anymore.
    (re: #5558, closes #8271, closes #8304)
    bhousel committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    90bbe38 View commit details
    Browse the repository at this point in the history
  2. Better handling of headGraph, separate head and base queues

    This involves a few things to make the validator less weird
    - _headGraph shouldn't be allowed to change while validation is happening..
    - So we don't allow that to happen anymore, and keep track of _headPromise and _headIsCurrent
    - If head graph falls behind, kick off another validation to catch it up
    - Separate head and base work queues, so we aren't waiting for the base entities to validate
      before providing feedback to the user about what they are editing
      (the base queue can get quite large around metropolitan areas)
    bhousel committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    7694335 View commit details
    Browse the repository at this point in the history
  3. Checkin en.min.json

    bhousel committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    4d9336b View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Configuration menu
    Copy the full SHA
    1f6a212 View commit details
    Browse the repository at this point in the history
  2. When displaying a preset image, use display:none for siblings

    visibility:hidden still preserves space, which would uncenter the image in some cases
    bhousel committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    42dccbf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc22678 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Configuration menu
    Copy the full SHA
    bbed217 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b1bf8e View commit details
    Browse the repository at this point in the history
  3. Improvements to name gathering

    - Actually bail out properly if namelike values contain semicolon ';'
    - Prioritize the canonical tags like `brand:wikidata`, `operator:wikidata`
    - Don't insert a name into 'alternate' set if it's already in 'primary' set
    bhousel committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    3f8faec View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7a82dba View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a656106 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Configuration menu
    Copy the full SHA
    a827e13 View commit details
    Browse the repository at this point in the history
  2. Support a more verbose format for listing issues

    Includes the feature type in the label
    (re: osmlab/name-suggestion-index#4543 (comment))
    bhousel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c3e9e8c View commit details
    Browse the repository at this point in the history
  3. Remember user's preference for expanding issue-info section

    This shows the tag diff, and other helpful information about the detected issues.
    It is expanded by default now
    (closes #6408, closes #8143)
    bhousel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    2b7adf8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Configuration menu
    Copy the full SHA
    9f30ebf View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Be smarter about identifying what tree an osm feature might be in

    Needed this after I added `highway=bus_stop` to the transit tree
    bhousel committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    19a8fd1 View commit details
    Browse the repository at this point in the history
  2. update imagery

    bhousel committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2e9c463 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    98a622f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d282140 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Create the categories like the presets

    The lack of locationSet was causing them to not show up, which indirectly
    broke the tutorial at the step where user needs to pick the road category.
    bhousel committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f95e7db View commit details
    Browse the repository at this point in the history
  2. Allow missing locationSetID on presets, fields, categories

    This simplifies the code a bit, just treat it as worldwide if missing
    bhousel committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    3cf5f69 View commit details
    Browse the repository at this point in the history
  3. Revise name/branch splitting code

    This now breaks the name into fragments and reruns the fragments against the NSi matcher
    rather than using flaky regular expressions. Has a few advantages:
    (re: osmlab/name-suggestion-index#4543 (comment))
    bhousel committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f5b6024 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Configuration menu
    Copy the full SHA
    77e7620 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Configuration menu
    Copy the full SHA
    55d9da9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec787f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9537911 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Configuration menu
    Copy the full SHA
    add1143 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Configuration menu
    Copy the full SHA
    0d79e8e View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. bump versions

    bhousel committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    3078f95 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Upgrade to name-suggestion-index v6

    Also bump country-coder and location-conflation
    bhousel committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    896d14b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Configuration menu
    Copy the full SHA
    bfb36d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8db1c1f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba01676 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2021

  1. Merge conflicts resolved

    mbrzakovic committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    d203699 View commit details
    Browse the repository at this point in the history