-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name-suggestion-index v6 #8305
Name-suggestion-index v6 #8305
Commits on Jan 5, 2021
-
Update to name-suggestion-index v5
Merge in NSI presets after UI has initialized
Configuration menu - View commit details
-
Copy full SHA for b0800c1 - Browse repository at this point
Copy the full SHA b0800c1View commit details
Commits on Jan 6, 2021
-
Update presetIndex to resolve and index locationSets
Added a deferred work queue to do this with requestIdleCallback in the background
Configuration menu - View commit details
-
Copy full SHA for 9eb6f87 - Browse repository at this point
Copy the full SHA 9eb6f87View commit details
Commits on Jan 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0ad7de0 - Browse repository at this point
Copy the full SHA 0ad7de0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab85590 - Browse repository at this point
Copy the full SHA ab85590View commit details -
Configuration menu - View commit details
-
Copy full SHA for 271e1c2 - Browse repository at this point
Copy the full SHA 271e1c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4daf1b - Browse repository at this point
Copy the full SHA c4daf1bView commit details
Commits on Jan 9, 2021
-
Have mergeLocationSets work on Objects, add locationSetID property
This means less work for the other parts of the code, now they don't need to chain that extra step after the promise.
Configuration menu - View commit details
-
Copy full SHA for 868db88 - Browse repository at this point
Copy the full SHA 868db88View commit details
Commits on Jan 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2d8c907 - Browse repository at this point
Copy the full SHA 2d8c907View commit details
Commits on Jan 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d3fb8c6 - Browse repository at this point
Copy the full SHA d3fb8c6View commit details
Commits on Jan 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0b3795c - Browse repository at this point
Copy the full SHA 0b3795cView commit details
Commits on Jan 18, 2021
-
Actually assign the locationSetID properties on the given objects
(should have been in 868db88)
Configuration menu - View commit details
-
Copy full SHA for a38a93c - Browse repository at this point
Copy the full SHA a38a93cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f39f73e - Browse repository at this point
Copy the full SHA f39f73eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4228b65 - Browse repository at this point
Copy the full SHA 4228b65View commit details
Commits on Jan 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 74d2825 - Browse repository at this point
Copy the full SHA 74d2825View commit details -
Configuration menu - View commit details
-
Copy full SHA for a325535 - Browse repository at this point
Copy the full SHA a325535View commit details -
Configuration menu - View commit details
-
Copy full SHA for f61a3ef - Browse repository at this point
Copy the full SHA f61a3efView commit details -
Preserve
name
value if this preset showsbrand
oroperator
fieldThis also fixes the logic for calculating whether the preset shows a `brand` or `operator` field - it needs to use `fields()` to actually resolve the fields, as these fields can be inherited from another preset. This also includes a change to match "primary" names before "alternate" names (aka the "Baby Gap" / "Gap" problem)
Configuration menu - View commit details
-
Copy full SHA for 96298f2 - Browse repository at this point
Copy the full SHA 96298f2View commit details
Commits on Jan 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4f369a8 - Browse repository at this point
Copy the full SHA 4f369a8View commit details
Commits on Jan 25, 2021
-
Rewrite the validator in ES6/Promises, several improvements here:
- implements a validation work queue, jobs are run during browser idle callbacks - when merging base entities, don't run validations 2x on both base and head graphs (this was wasteful) - keep track of resolved issues in a separate set (it's not a simple compare of base/head anymore) this happens after validation queue is empty and avoids race conditions and inaccurate resolved counts
Configuration menu - View commit details
-
Copy full SHA for 11201eb - Browse repository at this point
Copy the full SHA 11201ebView commit details
Commits on Jan 27, 2021
-
Allow validators to return provisional results, revalidate after delay
Also add a ton of commments to validator.js
Configuration menu - View commit details
-
Copy full SHA for f87c2d9 - Browse repository at this point
Copy the full SHA f87c2d9View commit details -
Merge pull request #8319 from openstreetmap/promisify_validation
Promisify validation
Configuration menu - View commit details
-
Copy full SHA for 16f2f07 - Browse repository at this point
Copy the full SHA 16f2f07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3640e15 - Browse repository at this point
Copy the full SHA 3640e15View commit details
Commits on Jan 28, 2021
-
Adust NSI matching validation code:
- don't try matching semicolon-separated lists to NSI - better matching for flagpoles with a `country` tag - better lists of namelike keys (don't match flag operator) see: #8305 (comment)
Configuration menu - View commit details
-
Copy full SHA for b032cd9 - Browse repository at this point
Copy the full SHA b032cd9View commit details
Commits on Jan 29, 2021
-
Also include
operator:wikidata
as a wikidata tagosmEntity#hasWikipedia was only used by the suspicious_name validator
Configuration menu - View commit details
-
Copy full SHA for 3665f80 - Browse repository at this point
Copy the full SHA 3665f80View commit details
Commits on Feb 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 90bbe38 - Browse repository at this point
Copy the full SHA 90bbe38View commit details -
Better handling of headGraph, separate head and base queues
This involves a few things to make the validator less weird - _headGraph shouldn't be allowed to change while validation is happening.. - So we don't allow that to happen anymore, and keep track of _headPromise and _headIsCurrent - If head graph falls behind, kick off another validation to catch it up - Separate head and base work queues, so we aren't waiting for the base entities to validate before providing feedback to the user about what they are editing (the base queue can get quite large around metropolitan areas)
Configuration menu - View commit details
-
Copy full SHA for 7694335 - Browse repository at this point
Copy the full SHA 7694335View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d9336b - Browse repository at this point
Copy the full SHA 4d9336bView commit details
Commits on Mar 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1f6a212 - Browse repository at this point
Copy the full SHA 1f6a212View commit details -
When displaying a preset image, use display:none for siblings
visibility:hidden still preserves space, which would uncenter the image in some cases
Configuration menu - View commit details
-
Copy full SHA for 42dccbf - Browse repository at this point
Copy the full SHA 42dccbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc22678 - Browse repository at this point
Copy the full SHA dc22678View commit details
Commits on Mar 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bbed217 - Browse repository at this point
Copy the full SHA bbed217View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b1bf8e - Browse repository at this point
Copy the full SHA 1b1bf8eView commit details -
Improvements to name gathering
- Actually bail out properly if namelike values contain semicolon ';' - Prioritize the canonical tags like `brand:wikidata`, `operator:wikidata` - Don't insert a name into 'alternate' set if it's already in 'primary' set
Configuration menu - View commit details
-
Copy full SHA for 3f8faec - Browse repository at this point
Copy the full SHA 3f8faecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a82dba - Browse repository at this point
Copy the full SHA 7a82dbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a656106 - Browse repository at this point
Copy the full SHA a656106View commit details
Commits on Mar 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a827e13 - Browse repository at this point
Copy the full SHA a827e13View commit details -
Support a more verbose format for listing issues
Includes the feature type in the label (re: osmlab/name-suggestion-index#4543 (comment))
Configuration menu - View commit details
-
Copy full SHA for c3e9e8c - Browse repository at this point
Copy the full SHA c3e9e8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b7adf8 - Browse repository at this point
Copy the full SHA 2b7adf8View commit details
Commits on Mar 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9f30ebf - Browse repository at this point
Copy the full SHA 9f30ebfView commit details
Commits on Mar 11, 2021
-
Be smarter about identifying what tree an osm feature might be in
Needed this after I added `highway=bus_stop` to the transit tree
Configuration menu - View commit details
-
Copy full SHA for 19a8fd1 - Browse repository at this point
Copy the full SHA 19a8fd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e9c463 - Browse repository at this point
Copy the full SHA 2e9c463View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98a622f - Browse repository at this point
Copy the full SHA 98a622fView commit details -
If we match a generic name, stop looking
This is for "nextbike" (re: osmlab/name-suggestion-index#4543 (comment))
Configuration menu - View commit details
-
Copy full SHA for d282140 - Browse repository at this point
Copy the full SHA d282140View commit details
Commits on Mar 12, 2021
-
Create the categories like the presets
The lack of locationSet was causing them to not show up, which indirectly broke the tutorial at the step where user needs to pick the road category.
Configuration menu - View commit details
-
Copy full SHA for f95e7db - Browse repository at this point
Copy the full SHA f95e7dbView commit details -
Allow missing locationSetID on presets, fields, categories
This simplifies the code a bit, just treat it as worldwide if missing
Configuration menu - View commit details
-
Copy full SHA for 3cf5f69 - Browse repository at this point
Copy the full SHA 3cf5f69View commit details -
Revise name/branch splitting code
This now breaks the name into fragments and reruns the fragments against the NSi matcher rather than using flaky regular expressions. Has a few advantages: (re: osmlab/name-suggestion-index#4543 (comment))
Configuration menu - View commit details
-
Copy full SHA for f5b6024 - Browse repository at this point
Copy the full SHA f5b6024View commit details
Commits on Mar 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 77e7620 - Browse repository at this point
Copy the full SHA 77e7620View commit details
Commits on Mar 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 55d9da9 - Browse repository at this point
Copy the full SHA 55d9da9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec787f8 - Browse repository at this point
Copy the full SHA ec787f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9537911 - Browse repository at this point
Copy the full SHA 9537911View commit details
Commits on Mar 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for add1143 - Browse repository at this point
Copy the full SHA add1143View commit details
Commits on Mar 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0d79e8e - Browse repository at this point
Copy the full SHA 0d79e8eView commit details
Commits on Jun 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3078f95 - Browse repository at this point
Copy the full SHA 3078f95View commit details
Commits on Jun 24, 2021
-
Upgrade to name-suggestion-index v6
Also bump country-coder and location-conflation
Configuration menu - View commit details
-
Copy full SHA for 896d14b - Browse repository at this point
Copy the full SHA 896d14bView commit details
Commits on Jul 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bfb36d5 - Browse repository at this point
Copy the full SHA bfb36d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8db1c1f - Browse repository at this point
Copy the full SHA 8db1c1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba01676 - Browse repository at this point
Copy the full SHA ba01676View commit details
Commits on Jul 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d203699 - Browse repository at this point
Copy the full SHA d203699View commit details