Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough bug: prompt suggests searching for 'cafe' feature type after selecting non-point shape during walkthrough #9439

Closed
jayaddison opened this issue Dec 25, 2022 · 4 comments
Labels
bug A bug - let's fix this! good first issue Best for first-time contributors. No experience necessary! walkthrough-help An issue with the walkthrough or help pane

Comments

@jayaddison
Copy link

URL

https://www.openstreetmap.org/edit

How to reproduce the issue?

  1. Open the 'Help' menu (shortcut: 'H')
  2. Begin the editing walkthrough
  3. Select the 'Points' walkthrough section
  4. Click the 'Point' icon to create a new point
  5. Click on the border of the building that appears in the middle of the transparent area
  6. Search for the word 'Cafe' as instructed by the tutorial

Bug: 'Cafe' does not appear in the feature type selection dropdown (the top result is 'Cape')

Screenshot(s) or anything else?

cafe

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app, RapiD version at mapwith.ai/rapid

What version numbers does this issue effect?

2.23.2 (iD), 2.24.0-dev (iD), 1.1.9 (RapiD)

Which browsers are you seeing this problem on?

Firefox

@jayaddison
Copy link
Author

Click on the border of the building that appears in the middle of the transparent area

It seems like this was the problem here. Creating a point within an unfilled region of the transparent area (where no border or other feature exists) results in a point being created, and Cafe can, as expected, be found and selected as the type for that feature.

If a bug remains here, then it is that the tutorial continues following a click on a border segment (way?).

@jayaddison jayaddison changed the title Walkthrough bug: unable to find suggested 'cafe' feature type during point editing tutorial Walkthrough bug: prompt suggests searching for 'cafe' feature type after selecting non-point shape during walkthrough Jan 2, 2023
@nickrsan nickrsan added bug A bug - let's fix this! good first issue Best for first-time contributors. No experience necessary! walkthrough-help An issue with the walkthrough or help pane labels Jun 28, 2023
@nickrsan
Copy link
Collaborator

I'm able to reproduce this issue. Adding the point to a way renders "Cafe" unfindable in the presets and the tutorial can't proceed, but adding it elsewhere makes it findable.

This issue should be a quick fix by changing tutorial text to tell people not to click on an existing line (maybe more complex if we want it to detect that the point is on a line). I'm going to mark this as a good first-time contribution issue.

@StillAbeginnerr
Copy link

Is it open? I want to contribute. @jayaddison

mattiapezzotti added a commit to mattiapezzotti/iD that referenced this issue Feb 25, 2024
mattiapezzotti added a commit to mattiapezzotti/iD that referenced this issue Feb 25, 2024
@riQQ

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! good first issue Best for first-time contributors. No experience necessary! walkthrough-help An issue with the walkthrough or help pane
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants