Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panoramax: Highlight stays loaded when switching to another provider #10361

Open
danieldegroot2 opened this issue Jul 30, 2024 · 1 comment
Open
Assignees
Labels
bug A bug - let's fix this! streetlevel An issue with streetlevel photos

Comments

@danieldegroot2
Copy link
Contributor

danieldegroot2 commented Jul 30, 2024

URL

No response

How to reproduce the issue?

Ref #9941

Switching from Panoramax to Mapillary, the highlight/ghost for Panoramax viewing direction is still visible.
Switching from Panoramax to Bing Streetside, it disappears but when hovering over it reappears.
workaround: closing the viewing window / disabling the layer removes any highlights.

Sidenote: Staying on screen also happens with Bing Streetside (eg. switch to Mapillary)

Chrome 127.0.6533.73 on Windows 10

Screenshot(s) or anything else?

Switching from Panoramax (left, white outline) to Mapillary (right, black outline), Panoramax highlight stays on screen

image

(some sequences in the example have been ported from Mapillary to Panoramax or vice versa.)

Which deployed environments do you see the issue in?

Development version at ideditor.netlify.app

What version numbers does this issue effect?

2.30.0-dev

Which browsers are you seeing this problem on?

Chrome

@tyrasd tyrasd added bug A bug - let's fix this! streetlevel An issue with streetlevel photos labels Jul 31, 2024
@tyrasd
Copy link
Member

tyrasd commented Jul 31, 2024

@mattiapezzotti this one seems to be not specific to panoramax layers, but can you check nonetheless how this might be fixed? The following may be of help: The update method (e.g. of the panoramax module) is also called whenever the image to be shown is from another provider: In that case, the method could check if there are any highlight-markers to clean up?!

mattiapezzotti added a commit to mattiapezzotti/iD that referenced this issue Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! streetlevel An issue with streetlevel photos
Projects
None yet
Development

No branches or pull requests

3 participants