Skip to content

Commit

Permalink
Fix swallowed error message in GroupDetector
Browse files Browse the repository at this point in the history
 ldapquery.IsQueryOutOfBoundsError(err) ||
 ldapquery.IsEntryNotFoundError(err) ||
 ldapquery.IsNoSuchObjectError(err)

Would return false but error was swallowed
  • Loading branch information
zerodayz committed Jan 27, 2021
1 parent 6f8f260 commit ab6be6f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/helpers/groupsync/groupdetector/groupdetector.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type GroupBasedDetector struct {
func (l *GroupBasedDetector) Exists(ldapGroupUID string) (bool, error) {
group, err := l.groupGetter.GroupEntryFor(ldapGroupUID)
if ldapquery.IsQueryOutOfBoundsError(err) || ldapquery.IsEntryNotFoundError(err) || ldapquery.IsNoSuchObjectError(err) {
return false, nil
return false, err
}
if err != nil {
return false, err
Expand Down

0 comments on commit ab6be6f

Please sign in to comment.