Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] 1.x version increment process, remove dependency zips. #383

Closed
prudhvigodithi opened this issue Jun 30, 2022 · 6 comments
Closed
Labels
enhancement New feature or request

Comments

@prudhvigodithi
Copy link
Contributor

prudhvigodithi commented Jun 30, 2022

Is your feature request related to a problem?
The version increment PR's for 1.x requires job-scheduler zips to be part of reports-scheduler/src/test/resources/bwc/job-scheduler/<version>-SNAPSHOT and reports-scheduler/src/test/resources/job-scheduler/ folder.
Sample PR:
https://github.com/opensearch-project/dashboards-reports/pull/366/files

What solution would you like?
Remove the injection of zip file via PR and use available latest URL to download the required zips
Example URL: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/latest/linux/x64/builds/opensearch/plugins/opensearch-job-scheduler-1.3.1.0.zip
This is already the case of version increments for 2.x the zips are not added as part of PR
Example 2.x version increment PR : https://github.com/opensearch-project/dashboards-reports/pull/371/files

What alternatives have you considered?
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/<version>/latest/linux/x64/builds/opensearch/plugins/<plugin name + version>.zip where <version> and plugin name parameter can be injected using gradle properties.

Do you have any additional context?
Committing a zip via a PR limits the capabilities to perform auto increment PR, more details on opensearch-project/opensearch-build#1375

@prudhvigodithi prudhvigodithi added enhancement New feature or request untriaged labels Jun 30, 2022
@prudhvigodithi
Copy link
Contributor Author

prudhvigodithi commented Jul 1, 2022

Hey @anirudha @joshuali925 can you take a look at this feature proposed.
@bbarani

@prudhvigodithi
Copy link
Contributor Author

Hey @anirudha @joshuali925 can you take a look at this, would really help for upcoming 1.3.5 release.
Solving this issue and back-porting the PR #391 to 1.3 should remove manual version increment PR's.
Thank you

@prudhvigodithi
Copy link
Contributor Author

Hey the version increment PR for 1.3.5 #420, has to have the plugin zip checked in every-time, its hard moving forward with this manual process, can someone please take a look at this issue.
Thank you
@bbarani @dblock @joshuali925 @anirudha

@prudhvigodithi
Copy link
Contributor Author

Hey @joshuali925 and @anirudha can you please post an update on this, this is pending to close the associated META issue.
Thank you

@joshuali925
Copy link
Member

joshuali925 commented Aug 25, 2022

Hey the version increment PR for 1.3.5 #420, has to have the plugin zip checked in every-time, its hard moving forward with this manual process, can someone please take a look at this issue.

future PRs like #420 won't need plugin zip checked in anymore because #422 is merged. do we still need 1.x?

@prudhvigodithi
Copy link
Contributor Author

Thanks @joshuali925 we dont need it as 1.3.x is the last supported version for 1.x. Closing this issue, we can reopen if required.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants