Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for archive and delete on report instances #170

Open
camAtGitHub opened this issue Sep 30, 2021 · 4 comments
Open

Add support for archive and delete on report instances #170

camAtGitHub opened this issue Sep 30, 2021 · 4 comments
Assignees
Labels

Comments

@camAtGitHub
Copy link

Describe the bug

Can't interact / delete / archive reports in the report plugin.
Deleted reports/searches have broken links.

To Reproduce
Steps to reproduce the behavior:

  1. Create saved search
  2. Reporting > Generate CSV
  3. Goto reporting dashboard https://DASHBOARD/app/reports-dashboards#/
    Note the line item of the on_demand_report
  4. Goto Discover > Goto Open > Manage Searches
  5. Find and delete the search you previously created
  6. Goto reporting dashboard https://DASHBOARD/app/reports-dashboards#/
    All links for the 'on_demand_report' are broken.
  7. No ability to clean up this section

Expected behavior
Ability to delete 'reports' as listed in the 'reports' section.
Same goes for reports with a source of 'Notebook'

OpenSearch Version
1.0.1

Dashboards Version
1.0.1

Plugins

Standard as per docker 1.0.1 image.

Screenshots
image

@camAtGitHub camAtGitHub changed the title [BUG] [BUG] Can't interact / delete / archive reports in the report plugin. Sep 30, 2021
@kavilla
Copy link
Member

kavilla commented Sep 30, 2021

Thanks @camAtGitHub, @opensearch-project/admin can you transfer this issue to https://github.com/opensearch-project/dashboards-reports

@peterzhuamazon peterzhuamazon transferred this issue from opensearch-project/OpenSearch-Dashboards Sep 30, 2021
@zhongnansu zhongnansu added the bug Something isn't working label Oct 1, 2021
@zhongnansu
Copy link
Member

The current implementation doesn't allow delete report instances from UI. The original purpose is to keep every report(not report definition) as audit trail. But I think the reported issue make sense for a real use case. I am thinking we improve the UX by adding additional checks to see if the saved objects(searches, dashboards, visualiztions) exist, before rendering report details page. If not exist, we show an alert to user. Basically we make sure user doesn't end up with a broken url, not being aware of what was the issue.

@kgcreative any thoughts on this?

@zhongnansu zhongnansu added the discuss need discussion label Oct 1, 2021
@zhongnansu zhongnansu added feature request and removed bug Something isn't working labels Oct 15, 2021
@zhongnansu
Copy link
Member

relabel it , since this is not a bug, but a feature request

@kgcreative
Copy link
Member

@zhongnansu - I think there are valid use cases where we might want to delete reports, either because someone created test reports they want to clean up, or becuase the underlying data has been archived, rolled over, or deleted and the report no longer can be generated. Let's work together on improving this.

@anirudha anirudha changed the title [BUG] Can't interact / delete / archive reports in the report plugin. Add support for archive and delete on report instances Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants