Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup maven and build dependencies using DependencyInstaller #276

Closed
Tracked by #232 ...
saratvemulapalli opened this issue Aug 19, 2021 · 2 comments
Closed
Tracked by #232 ...
Assignees

Comments

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Aug 19, 2021

Required for

@saratvemulapalli saratvemulapalli changed the title Checking out all component Git repositories (Could borrow from integtest.sh run) Setup maven dependencies for all components (Could borrow from integtest.sh run) Aug 23, 2021
@VachaShah VachaShah self-assigned this Aug 23, 2021
@dblock dblock changed the title Setup maven dependencies for all components (Could borrow from integtest.sh run) Setup maven dependencies for all components for bwc testing Aug 30, 2021
@setiah
Copy link
Contributor

setiah commented Sep 1, 2021

DependencyInstaller

Provides a way to install dependencies to Maven Local.

  • In P0, it pulls pre-built maven dependencies from S3.
  • In P1, it can also pull maven dependencies from internal or public maven repository.
  • Note - DependencyInstaller does not need to worry about concurrent builds overwriting each other dependencies. Docker configuration will support different mount points, so these dependencies can be synced to maven local within a docker.

Skeleton of methods required in DependencyInstaller -

class DependencyInstaller:
    def __init__():
        s3_loc
        component
        
    def installMavenDependenciesFromS3(dependency_list, s3_loc, custom_maven_local_path=None)
        """
        P0
        """
        
    def installBuildDependenciesFromS3(dependency_list, s3_loc_2):
        """
        P0 like job scheduler. 
        """
        
    def installMavenDependenciesFromS3(component, custom_maven_local_path=None)
        """
        TBD
        
        uses findDependencies to identify all dependencies for a given component.
        """
        
    def cleanUp()
        """
        
        Removes all downloaded dependencies in ~/.m2 or a custom directory.
        """
        
        
    def findDependencies(component)
        """
        TBD - Optional for now.
        
        identifies maven dependencies for a given component
        """

@setiah setiah changed the title Setup maven dependencies for all components for bwc testing Setup maven and build dependencies using DependencyInstaller Sep 3, 2021
@minalsha
Copy link

minalsha commented Sep 3, 2021

as part of the issue, you would need to also address:#331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants