Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][2.0.0]PA not running in RPM distribution #2043

Closed
peterzhuamazon opened this issue Apr 27, 2022 · 6 comments · Fixed by #2048
Closed

[BUG][2.0.0]PA not running in RPM distribution #2043

peterzhuamazon opened this issue Apr 27, 2022 · 6 comments · Fixed by #2048
Labels
bug Something isn't working release v2.0.0

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Apr 27, 2022

The error log:

ERROR StatusLogger Reconfiguration failed: No configuration found for '659e0bfd' at 'null' in 'null'
01:21:06.820 [main] ERROR org.opensearch.performanceanalyzer.config.PluginSettings - Loading config file /usr/share/opensearch/config/opensearch-performance-analyzer/performance-analyzer.properties failed with error: org.opensearch.performanceanalyzer.config.ConfigFileException: java.io.FileNotFoundException: /usr/share/opensearch/config/opensearch-performance-analyzer/performance-analyzer.properties (No such file or directory). Disabling plugin.
01:21:06.823 [main] ERROR org.opensearch.performanceanalyzer.PerformanceAnalyzerApp - Performance analyzer app stopped due to invalid config status.

This error is caused by the change of config directory in RPM.
Not in $OPENSEARCH_HOME/config anymore, but in /etc/opensearch.

How to resolve:

  1. We can have bin/opensearch-performance-analyzer/performance-analyzer-agent-cli to point to $OPENSEARCH_PATH_CONF instead of $OPENSEARCH_HOME/config.
  2. We can also create a config symlink in the rpm pointed to /etc/opensearch, the problem with this approach is security demo cert installation script is checking whether $OPENSEARCH_HOME/config exists. If so, install as tar; if not, install as rpm.

I prefer to have 1 as that is the minimum changes as well as changes in scripts/legacy/tar/linux/opensearch-tar-install.sh to add OPENSEARCH_PATH_CONF values and exports.

Thanks.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Apr 27, 2022

@peterzhuamazon peterzhuamazon changed the title [BUG] PA not running in RPM distribution [BUG][1.3.2]PA not running in RPM distribution Apr 27, 2022
@bbarani
Copy link
Member

bbarani commented Apr 27, 2022

@peterzhuamazon Can we also add automated validation for PA to capture these issues for RPM, TAR and Docker bundle once we align on a solution?

@dblock
Copy link
Member

dblock commented Apr 27, 2022

Is the fix in this repo or PA? Can we please move this issue to the right repo and assign to an engineer in PA?

@sruti1312
Copy link
Contributor

@peterzhuamazon I am also more inclined towards option 1. We can have performance-analyzer-agent-cli script pointing to OPENSEARCH_PATH_CONF.

PA references these configuration files in code as well, which needs to be fixed.

https://github.com/opensearch-project/performance-analyzer/blob/main/packaging/rpm/postinst
https://github.com/opensearch-project/performance-analyzer-rca/blob/main/src/main/java/org/opensearch/performanceanalyzer/config/PluginSettings.java#L219

@sruti1312
Copy link
Contributor

Created an issue in PA: opensearch-project/performance-analyzer#197

@peterzhuamazon
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release v2.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants