Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make input manifest combine version+qualifier like build/bundle manifest or vise versa #1965

Closed
peterzhuamazon opened this issue Apr 13, 2022 · 2 comments
Labels

Comments

@peterzhuamazon
Copy link
Member

As of now, 2.0.0 input_manifest separate the version and qualifier field.

version: 2.0.0
qualifier: alpha1

After build and assemble, the build_manifest and bundle_manifest combined this two fields into one.

version: 2.0.0-alpha1

This is not only confusing but also causing a lot of hard coding.

For example, rpm does not support - as stated in this issue comment. In order to separate version and qualifier with . instead of -, we want to directly call build.version and build.qualifier, but now we have to do version.replace('-', '.') which is not clean and is assuming the incoming version=2.0.0-alpha1.

I would like a consistent solution here, either separate the field for all or combine the field for all.

Thanks.

@dblock
Copy link
Member

dblock commented Apr 14, 2022

This would require changing how OpenSearch and plug-in gradle builds receive the build qualifier (remove support for it, include the qualifier as part of the version). It’s a good idea, but a lot of work.

@peterzhuamazon
Copy link
Member Author

Close this for now as nearly all the workflow is specifically coding differently for INPUT vs BUILD/BUNDLE manifest.s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants