Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Convert opensearch-docker-entrypoint.sh script into python #1541

Open
peternied opened this issue Jan 25, 2022 · 2 comments
Open

[Bug] Convert opensearch-docker-entrypoint.sh script into python #1541

peternied opened this issue Jan 25, 2022 · 2 comments
Labels
docker enhancement New Enhancement

Comments

@peternied
Copy link
Member

peternied commented Jan 25, 2022

Related #1529

Based on operation system configuration some command line utilities such as cat/sed/tee can have different behavior. In order to make the startup behavior consistent and testable lets move this script to python, which is included in the docker image already.

Acceptance Criteria:

  • There should be no library python dependencies needed that would require an update the docker image.
  • Create opensearch-docker-entrypoint.py that replaces the behavior of the existing entry point script
  • Create tests for this file that are verified on pull request
  • Make sure the pre-commit checks also apply to these files
@peternied peternied added untriaged Issues that have not yet been triaged bug Something isn't working labels Jan 25, 2022
@gaiksaya gaiksaya added docker and removed untriaged Issues that have not yet been triaged labels Jan 25, 2022
@gaiksaya
Copy link
Member

[Triage] We need to investigate the benefits of python over shell and vice versa.

@dblock
Copy link
Member

dblock commented Jan 28, 2022

I would prefer extracting much of what the code in shell scripts does into the product itself. For example, turning security on/off in the configuration file could become a command-line flag, etc.

@bbarani bbarani added enhancement New Enhancement and removed bug Something isn't working labels Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants