Issue: Unable to pickup Default Model id during search #664

eswarthammana · 2024-03-29T06:11:36Z

opensearch 2.11.1
python 3.11
opensearch-py 2.5.0

using the mentioned steps in the documentation with opensearch-py and requests module.

i have created a ingest pipeline with a default model id using PUT "/_ingest/pipeline/" and updated same in the index settings, which is working fine with out any issues.

Similarly i have created a search pipeline with a default model id using PUT "/_search/pipeline/" and updated same in the index settings under search.default_pipeline.

These settings got updated with proper model id and got verified.

when i perform search query, hybrid search with out model_id it throws null pointer exception as

java.lang.NullPointerException: modelId is marked non-null but is null
	at java.util.Objects.requireNonNull(Objects.java:235) ~[?:?]
	at org.opensearch.neuralsearch.ml.MLCommonsClientAccessor.inferenceSentences(MLCommonsClientAccessor.java:134) ~[?:?]
	at org.opensearch.neuralsearch.query.NeuralQueryBuilder.lambda$doRewrite$1(NeuralQueryBuilder.java:261) ~[?:?]
	at org.opensearch.index.query.QueryRewriteContext.executeAsyncActions(QueryRewriteContext.java:152) ~[opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.index.query.Rewriteable.rewriteAndFetch(Rewriteable.java:129) ~[opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.index.query.Rewriteable.rewriteAndFetch(Rewriteable.java:103) ~[opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.action.search.TransportSearchAction.executeRequest(TransportSearchAction.java:546) ~[opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.action.search.TransportSearchAction.doExecute(TransportSearchAction.java:310) ~[opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.action.search.TransportSearchAction.doExecute(TransportSearchAction.java:128) ~[opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.action.support.TransportAction$RequestFilterChain.proceed(TransportAction.java:218) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.indexmanagement.controlcenter.notification.filter.IndexOperationActionFilter.apply(IndexOperationActionFilter.kt:39) [opensearch-index-management-2.11.1.0.jar:2.11.1.0]
	at org.opensearch.action.support.TransportAction$RequestFilterChain.proceed(TransportAction.java:216) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.indexmanagement.rollup.actionfilter.FieldCapsFilter.apply(FieldCapsFilter.kt:118) [opensearch-index-management-2.11.1.0.jar:2.11.1.0]
	at org.opensearch.action.support.TransportAction$RequestFilterChain.proceed(TransportAction.java:216) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.action.support.TransportAction.execute(TransportAction.java:188) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.action.support.TransportAction.execute(TransportAction.java:107) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.client.node.NodeClient.executeLocally(NodeClient.java:110) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.rest.action.RestCancellableNodeClient.doExecute(RestCancellableNodeClient.java:106) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.client.support.AbstractClient.execute(AbstractClient.java:476) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.rest.action.search.RestSearchAction.lambda$prepareRequest$2(RestSearchAction.java:135) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.rest.BaseRestHandler.handleRequest(BaseRestHandler.java:128) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.rest.RestController.dispatchRequest(RestController.java:323) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.rest.RestController.tryAllHandlers(RestController.java:414) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.rest.RestController.dispatchRequest(RestController.java:252) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.http.AbstractHttpServerTransport.dispatchRequest(AbstractHttpServerTransport.java:385) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.http.AbstractHttpServerTransport.handleIncomingRequest(AbstractHttpServerTransport.java:466) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.http.AbstractHttpServerTransport.incomingRequest(AbstractHttpServerTransport.java:368) [opensearch-2.11.1.jar:2.11.1]
	at org.opensearch.http.netty4.Netty4HttpRequestHandler.channelRead0(Netty4HttpRequestHandler.java:56) [transport-netty4-client-2.11.1.jar:2.11.1]
	at org.opensearch.http.netty4.Netty4HttpRequestHandler.channelRead0(Netty4HttpRequestHandler.java:42) [transport-netty4-client-2.11.1.jar:2.11.1]
	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at org.opensearch.http.netty4.Netty4HttpPipeliningHandler.channelRead(Netty4HttpPipeliningHandler.java:72) [transport-netty4-client-2.11.1.jar:2.11.1]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [netty-codec-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [netty-codec-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) [netty-codec-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [netty-codec-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [netty-codec-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) [netty-codec-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318) [netty-codec-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) [netty-handler-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [netty-codec-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysPlain(NioEventLoop.java:689) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:652) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) [netty-transport-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) [netty-common-4.1.100.Final.jar:4.1.100.Final]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [netty-common-4.1.100.Final.jar:4.1.100.Final]

As per the documentation it shall accept with out model id but throws null pointer and if i pass model id the query works with out any issues.

Please do share your thoughts or suggestions.

The text was updated successfully, but these errors were encountered:

eswarthammana · 2024-03-29T06:31:37Z

it works fine without hybrid search. i mean in the case of semantic search with out id it works as mentioned in the documentation.

could you please share what is the proper syntax to make it work with hybrid search.

dblock · 2024-03-29T12:27:28Z

This is a server-side error, right? Moving to OpenSearch core repo.

peternied · 2024-04-03T15:53:29Z

[Triage - attendees 1 2 3 4 5 6 7 8]
@opensearch-project/admin Could you please transfer this to the neural search repository?

vibrantvarun · 2024-04-26T17:02:38Z

I will look into it

IanMenendez · 2024-04-30T19:01:14Z

@vibrantvarun have you found a fix? I have the same issue and I do not use hybrid search

vibrantvarun · 2024-05-01T00:49:46Z

Hey @IanMenendez @eswarthammana Can you add the default model Id setting in the normalization process itself. And do not create a separate search pipeline for default model id.

{
  "request_processors": [
    {
      "neural_query_enricher" : {
        "default_model_id": "ULR2MY8BBhy6g_i3SCfI"
      }
    }
  ],
  "phase_results_processors": [
        {
            "normalization-processor": {
                "normalization": {
                    "technique": "min_max"
                },
                "combination": {
                    "technique": "arithmetic_mean",
                    "parameters": {
                        // "weights": [
                        //     0.2,
                        //     0.6,
                        //     0.2
                        // ]
                    }
                }
            }
        }
    ]
}

vibrantvarun · 2024-05-01T00:49:57Z

It is not a bug.

vibrantvarun · 2024-05-01T00:50:21Z

I have just tested it on local and everything is working as expected.

IanMenendez · 2024-05-01T01:17:13Z

Thanks for testing it. I just found out the problem is related to my code searching the index through an alias and not the full name. Linked issue is: opensearch-project/OpenSearch#7512

vibrantvarun · 2024-05-14T17:52:36Z

Closing this issue. Feel free to open if still facing the issue.

IanMenendez · 2024-06-18T23:45:00Z

@vibrantvarun

Found out that NeuralQueryEnricher search processor is not working with NestedQueries
Other people are having the same issue: opensearch-project/OpenSearch#13961

how to reproduce:

PUT /_search/pipeline/test_pipeline 
{
  "request_processors": [
    {
      "neural_query_enricher" : {
        "default_model_id": "u5j0qYoBMtvQlfhaxOsa",
        "neural_field_default_id": {
           "embedding_field.knn": "uZj0qYoBMtvQlfhaYeud"
        }
      }
    }
  ]
}

GET testindex/_search?search_pipeline=test_pipeline
{
  "query": {
    "nested": {
      "score_mode": "max",
      "path": "passage_chunk_embedding",
      "query": {
        "neural": {
          "embedding_field.knn": {
            "query_text": "document"
          }
        }
      }
    }
  }
}

This should work but instead throws:

{
  "error": {
    "root_cause": [
      {
        "type": "null_pointer_exception",
        "reason": "modelId is marked non-null but is null"
      }
    ],
    "type": "null_pointer_exception",
    "reason": "modelId is marked non-null but is null"
  },
  "status": 500
}

github-actions bot added the untriaged label Mar 29, 2024

dblock transferred this issue from opensearch-project/opensearch-py Mar 29, 2024

bbarani transferred this issue from opensearch-project/OpenSearch Apr 3, 2024

vibrantvarun self-assigned this Apr 26, 2024

vamshin removed the untriaged label May 1, 2024

vibrantvarun closed this as completed May 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue: Unable to pickup Default Model id during search #664

Issue: Unable to pickup Default Model id during search #664

eswarthammana commented Mar 29, 2024

eswarthammana commented Mar 29, 2024

dblock commented Mar 29, 2024

peternied commented Apr 3, 2024

vibrantvarun commented Apr 26, 2024

IanMenendez commented Apr 30, 2024

vibrantvarun commented May 1, 2024

vibrantvarun commented May 1, 2024

vibrantvarun commented May 1, 2024

IanMenendez commented May 1, 2024

vibrantvarun commented May 14, 2024

IanMenendez commented Jun 18, 2024

Issue: Unable to pickup Default Model id during search #664

Issue: Unable to pickup Default Model id during search #664

Comments

eswarthammana commented Mar 29, 2024

eswarthammana commented Mar 29, 2024

dblock commented Mar 29, 2024

peternied commented Apr 3, 2024

vibrantvarun commented Apr 26, 2024

IanMenendez commented Apr 30, 2024

vibrantvarun commented May 1, 2024

vibrantvarun commented May 1, 2024

vibrantvarun commented May 1, 2024

IanMenendez commented May 1, 2024

vibrantvarun commented May 14, 2024

IanMenendez commented Jun 18, 2024