Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update remove ingest processor documentation for some metadata fields are not allowed to remove #5634

Closed
1 of 4 tasks
gaobinlong opened this issue Nov 20, 2023 · 5 comments · Fixed by #5870
Closed
1 of 4 tasks
Assignees
Labels
1 - Backlog - DEV Developer assigned to issue is responsible for creating PR.

Comments

@gaobinlong
Copy link
Contributor

gaobinlong commented Nov 20, 2023

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

We'll add some enhancement for the existing remove ingest processor, removing _index, _version, _version_type and _id with specific external version parameter will be not allowed because removing these metadata fields will cause issues, we need to modify the existing documentation to make that change clear for users.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

Related issue: opensearch-project/OpenSearch#10732
Related PR: opensearch-project/OpenSearch#10895

@hdhalter
Copy link
Contributor

hdhalter commented Nov 20, 2023

Thanks for creating this issue, @gaobinlong ! Will you be creating the associated PR for the updates?

@vagimeli for visibility.

@gaobinlong
Copy link
Contributor Author

Thanks for creating this issue, @gaobinlong ! Will you be creating the associated PR for the updates?

@vagimeli for visibility.

Yeah, I'll create a PR for this later.

@hdhalter hdhalter added 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. and removed untriaged labels Nov 21, 2023
@hdhalter
Copy link
Contributor

Thanks, @gaobinlong ! And please let us know which versions this change will apply to.

@gaobinlong
Copy link
Contributor Author

gaobinlong commented Nov 22, 2023

Hi @hdhalter ,this change will apply to version 2.12.0 and above.

@gaobinlong
Copy link
Contributor Author

Closed by #5870 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Backlog - DEV Developer assigned to issue is responsible for creating PR.
Projects
None yet
2 participants