Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OpenSearch Sink failures are masked by max retry in the logs #2597

Closed
cmanning09 opened this issue Apr 26, 2023 · 2 comments · Fixed by #2605
Closed

[BUG] OpenSearch Sink failures are masked by max retry in the logs #2597

cmanning09 opened this issue Apr 26, 2023 · 2 comments · Fixed by #2605
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cmanning09
Copy link
Contributor

Describe the bug
Writing to the OpenSearch sink may encounter failures. These were originally provided after the final failure occurred. The recent change to the failure handling overwrites the error message masking it from the operator. This makes it difficult to debug failure scenarios:

WARN  org.opensearch.dataprepper.plugins.sink.opensearch.OpenSearchSink - Document [******] has failure.
java.lang.RuntimeException: Number of retries reached the limit of max retries(configured value 10)

Expected behavior
Log the original failure associated with

Additional context

@cmanning09 cmanning09 added bug Something isn't working untriaged labels Apr 26, 2023
@cmanning09 cmanning09 changed the title [BUG] OpenSearch Sink failure Logs are masked by max retry [BUG] OpenSearch Sink failures are masked by max retry in the logs Apr 26, 2023
@dlvenable dlvenable added this to the v2.3 milestone Apr 26, 2023
@kkondaka
Copy link
Collaborator

I will look into this. Please assign this to me.

@dlvenable
Copy link
Member

Thanks, @kkondaka !

Along with this change, it may be useful to log periodically. Right now, if the sink continues to fail before reaching max_retries there is no indication in the logging. You can find this in the metrics however.

Perhaps every 5-10 failures log a message about failing to write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
3 participants