Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BWC Failure on version increment #586

Closed
amitgalitz opened this issue Jun 24, 2022 · 0 comments · Fixed by #611
Closed

BWC Failure on version increment #586

amitgalitz opened this issue Jun 24, 2022 · 0 comments · Fixed by #611
Labels
bug Something isn't working infra Changes to infrastructure, testing, CI/CD, pipelines, etc. untriaged

Comments

@amitgalitz
Copy link
Member

What is the bug?

Currently in order to run our BWC tests we need to pull the latest AD artifact from ci.opensearch.org. However, when increment version for AD we run into circular problem. For example when upgrading from 2.0 to 2.1, our CI tries to pull the latest AD version which is 2.1 from ci.openearch.org but since we haven't yet pushed our version increment commit, the artifact doesn't exist yet.

How can one reproduce the bug?
Steps to reproduce the behavior:
Version Increment PR: #567

Do you have any additional context?

At the moment we are bypassing this check for the first intial PR by just merging the version increment which then leads to its upload so it can be fetched later on. We then either manually run the CI again on the main branch or check for BWC on the next upcoming PR.

This however isn't the right way to do things because we could miss a bwc failure on the initial PR merge. I propose that we add some sort of check that if there is no artifact available from AD we will build it during our CI run and utilize that zip itself.

@amitgalitz amitgalitz added bug Something isn't working infra Changes to infrastructure, testing, CI/CD, pipelines, etc. untriaged labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infra Changes to infrastructure, testing, CI/CD, pipelines, etc. untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant