Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracing Instrumentation] Add instrumentation at deep search path #8554

Closed
Tracked by #12082
Gaganjuneja opened this issue Jul 9, 2023 · 3 comments · Fixed by #12103
Closed
Tracked by #12082

[Tracing Instrumentation] Add instrumentation at deep search path #8554

Gaganjuneja opened this issue Jul 9, 2023 · 3 comments · Fixed by #12103
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v2.13.0 Issues and PRs related to version 2.13.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@Gaganjuneja
Copy link
Contributor

Gaganjuneja commented Jul 9, 2023

Is your feature request related to a problem? Please describe.
Now the distributed tracing framework #7543 is available. We need to add the tracing instrumentation at several places to effectively monitoring the overall OpenSearch. Creating this task to add instrumentation at deep search path like coordinator, shard, segments, lucene calls, etc.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Gaganjuneja Gaganjuneja added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 9, 2023
@minalsha minalsha added the Search Search query, autocomplete ...etc label Jul 14, 2023
@macohen macohen removed the untriaged label Jul 17, 2023
@macohen
Copy link
Contributor

macohen commented Jul 17, 2023

@Gaganjuneja thanks for opening this issue! can you please add more information to your request about what metrics you want to capture? What outcome are you looking for? What analytics do you want? What will you do with this data?

@Gaganjuneja
Copy link
Contributor Author

@Gaganjuneja thanks for opening this issue! can you please add more information to your request about what metrics you want to capture? What outcome are you looking for? What analytics do you want? What will you do with this data?

Thanks @macohen for your reply, I have created a Meta task #8553 for instrumentations in OpenSearch code paths. I have updated the description. Contributor can add further details while picking it up for implementation.

@kkhatua
Copy link
Member

kkhatua commented Aug 18, 2023

One thing to note is that there is a much higher level tracing being done under #7334
This might appear as an overlap, but the granularity is the primary difference.

@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.13.0 Issues and PRs related to version 2.13.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v2.13.0 Issues and PRs related to version 2.13.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants